Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

METAL-730: Sync202310 #407

Merged
merged 1 commit into from Nov 8, 2023
Merged

METAL-730: Sync202310 #407

merged 1 commit into from Nov 8, 2023

Conversation

elfosardo
Copy link

Reverts #405 which is the revert of #395
We try to reapply the same changes but testing also on ipv6

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@elfosardo
Copy link
Author

as expected ipv6 is indeed failing

@elfosardo
Copy link
Author

I believe I found the isse
AH00526: Syntax error on line 8 of /etc/httpd/conf/httpd.conf:
Invalid ServerName "[fd00:1101::1]:80" use ServerAlias to set multiple server names.

@elfosardo elfosardo force-pushed the revert-405-revert-395-1696595843385 branch from d22d5d4 to ce895de Compare November 7, 2023 14:20
@elfosardo
Copy link
Author

elfosardo commented Nov 7, 2023 •
edited

proposed fix upstream metal3-io#442

also included the fix in this patch

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2023

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo elfosardo changed the title Sync202310 METAL-730: Sync202310 Nov 8, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2023 •
edited by openshift-ci bot

@elfosardo: This pull request references METAL-730 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #405 which is the revert of #395
We try to reapply the same changes but testing also on ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2023 •
edited by openshift-ci bot

@elfosardo: This pull request references METAL-730 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit dbccf56 into master Nov 8, 2023
7 checks passed
@stbenjam stbenjam mentioned this pull request Nov 9, 2023
Closed
stbenjam added a commit to stbenjam/ironic-image that referenced this pull request Nov 9, 2023
@stbenjam
Revert "Merge pull request openshift#407 from openshift/revert-405-re…
689b836 
…vert-395-1696595843385"

This reverts commit dbccf56, reversing
changes made to cec9f68.
jupierce pushed a commit to jupierce/ironic-image that referenced this pull request Mar 1, 2024
@metal3-io-bot
Merge pull request openshift#407 from Nordix/tuomo/update-book-link
0aefcb4 
update user-guide url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@derekhiggins derekhiggins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elfosardo @openshift-ci-robot @derekhiggins