Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-944: Install ironic-lib from source #463

Merged

Conversation

elfosardo
Copy link

No description provided.

Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@elfosardo elfosardo changed the title Install ironic-lib from source METAL-944: Install ironic-lib from source Mar 14, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2024

@elfosardo: This pull request references METAL-944 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo elfosardo added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 14, 2024
@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
production has passed so we're good

Copy link

openshift-ci bot commented Mar 15, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
production has passed so we're good

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Mar 15, 2024

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link
Author

/hold
let's wait for after the weekend

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2024
@elfosardo
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2024
@@ -71,6 +70,7 @@ python3-sushy >= 4.7.1-0.20240118192507.435e7d1.el9
python3-sushy-oem-idrac >= 5.0.0-0.20231218155726.da9a0e4.el9
python3-tooz >= 4.2.0-0.20231214201931.bed303e.el9
python3-werkzeug >= 2.2.3-2.el9
python3-zeroconf >= 0.24.4-2.el9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: consider dropping this

@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 73f0d22 into openshift:master Mar 18, 2024
12 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-container-v4.16.0-202403181742.p0.g73f0d22.assembly.stream.el9 for distgit ironic.
All builds following this will include this PR.

rhjanders pushed a commit to rhjanders/ironic-image that referenced this pull request May 12, 2024
add condition for ipxe_tls template usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants