Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-804: Bump ironic hash to include recent fixes and features #465

Merged
merged 1 commit into from Mar 28, 2024

Conversation

elfosardo
Copy link

This adds the redfish implementation of attach/detach generic iso.

Copy link

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
This adds the redfish implementation of attach/detach generic iso.
Bump sushy version as required dependency.
@elfosardo elfosardo changed the title Bump ironic hash to include recent fixes and features METAL-804: Bump ironic hash to include recent fixes and features Mar 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@elfosardo: This pull request references METAL-804 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This adds the redfish implementation of attach/detach generic iso.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
Copy link
Author

/test prevalidation-images

2 similar comments
@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/retest

@lhh
Copy link

lhh commented Mar 25, 2024

/retest

@lhh
Copy link

lhh commented Mar 25, 2024

Looks like the package hadn't appeared in the repos; rerunning tests

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

/retest

@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 73f0d22 and 2 for PR HEAD 9b8b99a in total

@elfosardo
Copy link
Author

I can see from the logs that the cluster does get initialized so I'm going to override the virtualmedia prevalidation test
the rest looks good, just waiting for the sushy package to be synced to production

@elfosardo
Copy link
Author

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/test images

Copy link

openshift-ci bot commented Mar 27, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/retest

1 similar comment
@elfosardo
Copy link
Author

/retest

Copy link

openshift-ci bot commented Mar 28, 2024

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6ffbcc7 into openshift:master Mar 28, 2024
12 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-container-v4.16.0-202403281444.p0.g6ffbcc7.assembly.stream.el9 for distgit ironic.
All builds following this will include this PR.

rhjanders pushed a commit to rhjanders/ironic-image that referenced this pull request May 12, 2024
📖 add OpenSSF Scorecard badge to README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants