Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-32351: [4.15] Update to include fixes for ironic servicing feature #479

Merged
merged 1 commit into from
Apr 29, 2024
Merged

OCPBUGS-32351: [4.15] Update to include fixes for ironic servicing feature #479

merged 1 commit into from
Apr 29, 2024

Conversation

elfosardo
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 23, 2024
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Jira Issue OCPBUGS-32351, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32350 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@elfosardo elfosardo added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 23, 2024
@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-bm-prevalidation prevalidation-e2e-metal-ipi-virtualmedia-prevalidation prevalidation-e2e-metal-ipi-ovn-ipv6-prevalidation

@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/override ci/prow/e2e-metal-ipi-bm ci/prow/e2e-metal-ipi-ovn-ipv6 ci/prow/e2e-metal-ipi-virtualmedia
prevalidation jobs are the same, we can override the normal jobs

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 24, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-bm, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-virtualmedia

In response to this:

/override ci/prow/e2e-metal-ipi-bm ci/prow/e2e-metal-ipi-ovn-ipv6 ci/prow/e2e-metal-ipi-virtualmedia
prevalidation jobs are the same, we can override the normal jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

/jira refresh
/lgtm

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 26, 2024
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Jira Issue OCPBUGS-32351, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-32350 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32350 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @jadhaj

In response to this:

/jira refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jadhaj April 26, 2024 13:42
@dtantsur
Copy link
Member

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 26, 2024 •
edited

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia cca7733 link true /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm cca7733 link true /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-ovn-ipv6 cca7733 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link
Author

/retest

@pamoedom
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a747623 into openshift:release-4.15 Apr 29, 2024
12 checks passed
@openshift-ci-robot
Copy link

@elfosardo: Jira Issue OCPBUGS-32351: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32351 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-container-v4.15.0-202404291137.p0.ga747623.assembly.stream.el9 for distgit ironic.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.15.0-0.nightly-2024-04-29-230005

openshift-merge-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@metal3-io-bot
Merge pull request #479 from dtantsur/no-inspector
6664e02 
⚠️ Disable ironic-inspector by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfournie bfournie Awaiting requested review from bfournie

@dtantsur dtantsur Awaiting requested review from dtantsur

@jadhaj jadhaj Awaiting requested review from jadhaj

Assignees

@dtantsur dtantsur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@elfosardo @openshift-ci-robot @dtantsur @pamoedom @openshift-bot @openshift-merge-robot