Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32366: [4.16] remove unused prometheus-exporter from OKD too #486

Conversation

elfosardo
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 29, 2024
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Jira Issue OCPBUGS-32366, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 29, 2024
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Jira Issue OCPBUGS-32366, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@elfosardo
Copy link
Author

/override ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation ci/prow/prevalidation-e2e-metal-ipi-ovn-ipv6-prevalidation ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

this is just for OKD so CI is not really impacted except for the okd-images job which is green

@dtantsur
Copy link
Member

/lgtm

@elfosardo
Copy link
Author

/override ci/prow/images
wrong trigger, okd job already passed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link

openshift-ci bot commented Apr 29, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation, ci/prow/prevalidation-e2e-metal-ipi-ovn-ipv6-prevalidation, ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation ci/prow/prevalidation-e2e-metal-ipi-ovn-ipv6-prevalidation ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Apr 29, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/images

In response to this:

/override ci/prow/images
wrong trigger, okd job already passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9e2384d into openshift:master Apr 29, 2024
8 checks passed
@openshift-ci-robot
Copy link

@elfosardo: Jira Issue OCPBUGS-32366: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32366 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Apr 29, 2024

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-container-v4.16.0-202404291547.p0.g9e2384d.assembly.stream.el9 for distgit ironic.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants