Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-32363: [4.13] remove unused prometheus-exporter #488

Merged
merged 1 commit into from
Apr 30, 2024
Merged

OCPBUGS-32363: [4.13] remove unused prometheus-exporter #488

merged 1 commit into from
Apr 30, 2024

Conversation

elfosardo
Copy link

@elfosardo elfosardo commented Apr 29, 2024 •
edited

Also removing outdated repositories for okd and using the
correct ones from RDO

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 29, 2024
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Jira Issue OCPBUGS-32363, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-32363 to depend on a bug targeting a version in 4.14.0, 4.14.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo elfosardo added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 29, 2024
@elfosardo
Copy link
Author

/override ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
this change impacts only images jobs

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 29, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation, ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
this change impacts only images jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo elfosardo force-pushed the remove-prometheus-exporter-413 branch 2 times, most recently from c5a12e6 to c2ec6c1 Compare April 29, 2024 14:33
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Jira Issue OCPBUGS-32363, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32364 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Also removing outdated repositories for okd and using the
correct ones from RDO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
[4.13] remove unused prometheus-exporter
7f0c63b 
Also removing outdated repositories for okd and using the
correct ones from RDO
@elfosardo elfosardo force-pushed the remove-prometheus-exporter-413 branch from c2ec6c1 to 7f0c63b Compare April 29, 2024 14:33
@elfosardo
Copy link
Author

/override ci/prow/e2e-metal-ipi-bm ci/prow/e2e-metal-ipi-virtualmedia ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
we don't have tests for exporter in the CI jobs

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 30, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-bm, ci/prow/e2e-metal-ipi-virtualmedia, ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation, ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

In response to this:

/override ci/prow/e2e-metal-ipi-bm ci/prow/e2e-metal-ipi-virtualmedia ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
we don't have tests for exporter in the CI jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 30, 2024

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/prevalidation-e2e-metal-ipi-bm-prevalidation 7f0c63b link true /test prevalidation-e2e-metal-ipi-bm-prevalidation
ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation 7f0c63b link true /test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
ci/prow/e2e-metal-ipi-virtualmedia 7f0c63b link true /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm 7f0c63b link true /test e2e-metal-ipi-bm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@metal3-io-bot
Merge pull request #488 from dtantsur/deprecate-drivers
0fcde1d 
⚠️ Remove ibmc and idrac drivers
@iurygregory iurygregory added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@jadhaj
Copy link

jadhaj commented Apr 30, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 30, 2024
@elfosardo
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2024
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Jira Issue OCPBUGS-32363, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-32364 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32364 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @jadhaj

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jadhaj April 30, 2024 14:17
@openshift-merge-bot openshift-merge-bot bot merged commit 881e793 into openshift:release-4.13 Apr 30, 2024
9 checks passed
@openshift-ci-robot
Copy link

@elfosardo: Jira Issue OCPBUGS-32363: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32363 has been moved to the MODIFIED state.

In response to this:

Also removing outdated repositories for okd and using the
correct ones from RDO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-container-v4.13.0-202404301436.p0.g881e793.assembly.stream.el9 for distgit ironic.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@zaneb zaneb Awaiting requested review from zaneb

@jadhaj jadhaj Awaiting requested review from jadhaj

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elfosardo @openshift-ci-robot @jadhaj @openshift-bot @iurygregory