Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1796154: Temporarily disable cleaning as a workaround #51

Closed
wants to merge 1 commit into from
Closed

[release-4.3] Bug 1796154: Temporarily disable cleaning as a workaround #51

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #50

/assign stbenjam

@juliakreger
Temporarily disable cleaning as a workaround
cbe121a 
The HPE virtual install device presents a virtual, emulated, read-only
spinning disk which fails cleaning operaitons in preparation for deployment.

This device is bios controlled, and is unable to be disabled by the user.
The bios may hide it in some cases if previously disabled before the bios
version is updated, or if "intellegent provisioning" has completed on the
host as the volume is intended for installation of other operating
systems.

Some more information can be found in storyboard:

https://storyboard.openstack.org/#!/story/2007229

This patch will likely be reverted once a fix for the device handling is
available in ironic-python-agent for downstream consumption.

rhbz: #1796141
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 29, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 29, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1796141, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1796141 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1796141: Temporarily disable cleaning as a workaround

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2020
@stbenjam
Copy link
Member

/retitle [release-4.3] Bug 1796154: Temporarily disable cleaning as a workaround

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1796141: Temporarily disable cleaning as a workaround [release-4.3] Bug 1796154: Temporarily disable cleaning as a workaround Jan 29, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1796154, which is invalid:

  • expected dependent Bugzilla bug 1796141 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1796154: Temporarily disable cleaning as a workaround

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

/lgtm

To get this merged into 4.3, I think we'd have to move the 4.4 BZ to "VERIFIED" state...

/cc @juliakreger

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@derekhiggins
Copy link

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, openshift-cherrypick-robot, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@juliakreger
Copy link

Requirements have changed, we can close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@juliakreger juliakreger Awaiting requested review from juliakreger

Assignees

@stbenjam stbenjam

@derekhiggins derekhiggins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @stbenjam @derekhiggins @juliakreger