New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1807633: Copy snpnoly.efi to tftpboot directory #54
Conversation
@stbenjam: This pull request references Bugzilla bug 1807633, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) run on this bug- bug is open, matching expected state (open) - bug target release (4.5.0) matches configured target release for branch (4.5.0) - bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@stbenjam: This pull request references Bugzilla bug 1807633, which is valid. 3 validation(s) run on this bug- bug is open, matching expected state (open) - bug target release (4.5.0) matches configured target release for branch (4.5.0) - bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
This is required for doing UEFI + IPv6 provisioning. It requires updated iPXE packages. This restores the prepare-ipxe.sh script to ensure image build fails if all images are not present. Otherwise we don't detect failure until the dnsmasq service itself starts.
What's interesting after #43, is image building won't fail if we're missing particular ipxe images because we don't copy them until rundnsmasq. I think that probably shouldn't be the case... so I've put that script back. @derekhiggins What do you think about that? It essentially reverts #43 |
Job is correctly failing now:
|
/hold cancel |
I'm ok with check/failing at build time, once the new ipxe package is available it might seem unnecessary, I mean any package could potentially remove a file we require but these are the only ones well be testing.
So we are waiting for the new ipxe package to appear, correct? |
Yea, work is in progress to get them in a repo we can build from. Once it's there I'll /retest. |
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
@openshift-bot: This pull request references Bugzilla bug 1807633, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
2 similar comments
/retest |
/retest |
@@ -23,6 +23,9 @@ RUN dnf update -y && \ | |||
dnf clean all && \ | |||
rm -rf /var/cache/{yum,dnf}/* | |||
|
|||
COPY ./prepare-ipxe.sh /tmp | |||
RUN chmod +x /tmp/prepare-ipxe.sh && /tmp/prepare-ipxe.sh && rm /tmp/prepare-ipxe.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: split into different lines for better visualization
/retest |
2 similar comments
/retest |
/retest |
GitHub is having issues again :-( |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you switching due to ipxe.efi crashing freezing on initialization in libvirt VMs?
I have had the same issue, and used snponly.efi as well.
Not just libvirt but yes, it’s more reliable to use the uefi network stack |
/retest |
7 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
1 similar comment
/retest |
/lgtm |
@stbenjam: All pull requests linked via external trackers have merged. Bugzilla bug 1807633 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -23,6 +23,9 @@ RUN dnf update -y && \ | |||
dnf clean all && \ | |||
rm -rf /var/cache/{yum,dnf}/* | |||
|
|||
COPY ./prepare-ipxe.sh /tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: why not:
RUN bash /tmp/prepare-ipxe.sh
?
This is required for doing UEFI + IPv6 provisioning. It requires updated
iPXE packages.
--
Note: To be cherry-picked to 4.4 and 4.3.z, but will need to be done manually as it should include #43 as well.
4.4 BZ: 1807634
4.3 BZ: 1807635