Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1807633: Copy snpnoly.efi to tftpboot directory #54

Merged
merged 1 commit into from Mar 2, 2020
Merged

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Feb 26, 2020

This is required for doing UEFI + IPv6 provisioning. It requires updated
iPXE packages.

--
Note: To be cherry-picked to 4.4 and 4.3.z, but will need to be done manually as it should include #43 as well.

4.4 BZ: 1807634
4.3 BZ: 1807635

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 26, 2020
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Bugzilla bug 1807633, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) run on this bug - bug is open, matching expected state (open) - bug target release (4.5.0) matches configured target release for branch (4.5.0) - bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1807633: Copy snpnoly.efi to tftpboot directory

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2020
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Bugzilla bug 1807633, which is valid.

3 validation(s) run on this bug - bug is open, matching expected state (open) - bug target release (4.5.0) matches configured target release for branch (4.5.0) - bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1807633: Copy snpnoly.efi to tftpboot directory

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
This is required for doing UEFI + IPv6 provisioning. It requires updated
iPXE packages. This restores the prepare-ipxe.sh script to ensure image
build fails if all images are not present. Otherwise we don't detect
failure until the dnsmasq service itself starts.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2020
@stbenjam
Copy link
Member Author

stbenjam commented Feb 26, 2020

What's interesting after #43, is image building won't fail if we're missing particular ipxe images because we don't copy them until rundnsmasq. I think that probably shouldn't be the case... so I've put that script back. @derekhiggins What do you think about that? It essentially reverts #43

@stbenjam
Copy link
Member Author

Job is correctly failing now:

+ cp /usr/share/ipxe/ipxe-snponly-x86_64.efi /tftpboot/snponly.efi
cp: cannot stat '/usr/share/ipxe/ipxe-snponly-x86_64.efi': No such file or directory
error: build error: running 'chmod +x /tmp/prepare-ipxe.sh...ipxe.sh && rm /tmp/prepare-ipxe.sh' failed with exit code 1

@stbenjam
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
@derekhiggins
Copy link

What's interesting after #43, is image building won't fail if we're missing particular ipxe images because we don't copy them until rundnsmasq.conf. I think that probably shouldn't be the case... so I've put that script back. @derekhiggins What do you think about that? It essentially reverts #43

I'm ok with check/failing at build time, once the new ipxe package is available it might seem unnecessary, I mean any package could potentially remove a file we require but these are the only ones well be testing.

Job is correctly failing now:

+ cp /usr/share/ipxe/ipxe-snponly-x86_64.efi /tftpboot/snponly.efi
cp: cannot stat '/usr/share/ipxe/ipxe-snponly-x86_64.efi': No such file or directory
error: build error: running 'chmod +x /tmp/prepare-ipxe.sh...ipxe.sh && rm /tmp/prepare-ipxe.sh' failed with exit code 1

So we are waiting for the new ipxe package to appear, correct?

@stbenjam
Copy link
Member Author

What's interesting after #43, is image building won't fail if we're missing particular ipxe images because we don't copy them until rundnsmasq.conf. I think that probably shouldn't be the case... so I've put that script back. @derekhiggins What do you think about that? It essentially reverts #43

I'm ok with check/failing at build time, once the new ipxe package is available it might seem unnecessary, I mean any package could potentially remove a file we require but these are the only ones well be testing.

Job is correctly failing now:

+ cp /usr/share/ipxe/ipxe-snponly-x86_64.efi /tftpboot/snponly.efi
cp: cannot stat '/usr/share/ipxe/ipxe-snponly-x86_64.efi': No such file or directory
error: build error: running 'chmod +x /tmp/prepare-ipxe.sh...ipxe.sh && rm /tmp/prepare-ipxe.sh' failed with exit code 1

So we are waiting for the new ipxe package to appear, correct?

Yea, work is in progress to get them in a repo we can build from. Once it's there I'll /retest.

@openshift-bot
Copy link

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Bugzilla bug 1807633, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

/retest

2 similar comments
@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

/retest

@@ -23,6 +23,9 @@ RUN dnf update -y && \
dnf clean all && \
rm -rf /var/cache/{yum,dnf}/*

COPY ./prepare-ipxe.sh /tmp
RUN chmod +x /tmp/prepare-ipxe.sh && /tmp/prepare-ipxe.sh && rm /tmp/prepare-ipxe.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: split into different lines for better visualization

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@stbenjam
Copy link
Member Author

/retest

2 similar comments
@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

GitHub is having issues again :-(

https://www.githubstatus.com/

@stbenjam
Copy link
Member Author

/retest

1 similar comment
@stbenjam
Copy link
Member Author

/retest

Copy link

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you switching due to ipxe.efi crashing freezing on initialization in libvirt VMs?

I have had the same issue, and used snponly.efi as well.

@stbenjam
Copy link
Member Author

Not just libvirt but yes, it’s more reliable to use the uefi network stack

@stbenjam
Copy link
Member Author

/retest

7 similar comments
@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

/retest

@jupierce
Copy link

/retest

@elfosardo
Copy link

/retest

1 similar comment
@elfosardo
Copy link

/retest

@elfosardo
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 36c6e32 into openshift:master Mar 2, 2020
@openshift-ci-robot
Copy link

@stbenjam: All pull requests linked via external trackers have merged. Bugzilla bug 1807633 has been moved to the MODIFIED state.

In response to this:

Bug 1807633: Copy snpnoly.efi to tftpboot directory

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam stbenjam deleted the ipxe branch March 2, 2020 17:41
@@ -23,6 +23,9 @@ RUN dnf update -y && \
dnf clean all && \
rm -rf /var/cache/{yum,dnf}/*

COPY ./prepare-ipxe.sh /tmp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why not:

RUN bash /tmp/prepare-ipxe.sh

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants