New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1811573: Remove custom healthchecks #66
Bug 1811573: Remove custom healthchecks #66
Conversation
Health checking from inside the container has a limited use, and the way we're doing it now doesn't work without built-in DHCP. Removing it to solve the immediate problem while we're working on proper health checks. Conflicts: Dockerfile rundnsmasq.sh runhttpd.sh
@dtantsur: This pull request references Bugzilla bug 1811573, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@dtantsur: This pull request references Bugzilla bug 1811573, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
/cherry-pick-approved |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dtantsur: All pull requests linked via external trackers have merged. Bugzilla bug 1811573 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Health checking from inside the container has a limited use, and
the way we're doing it now doesn't work without built-in DHCP.
Removing it to solve the immediate problem while we're working
on proper health checks.
Conflicts:
Dockerfile
rundnsmasq.sh
runhttpd.sh