Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1811573: Remove custom healthchecks #66

Merged

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Mar 9, 2020

Health checking from inside the container has a limited use, and
the way we're doing it now doesn't work without built-in DHCP.
Removing it to solve the immediate problem while we're working
on proper health checks.

Conflicts:
Dockerfile
rundnsmasq.sh
runhttpd.sh

Health checking from inside the container has a limited use, and
the way we're doing it now doesn't work without built-in DHCP.
Removing it to solve the immediate problem while we're working
on proper health checks.

Conflicts:
	Dockerfile
	rundnsmasq.sh
	runhttpd.sh
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Bugzilla bug 1811573, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead
  • expected dependent Bugzilla bug 1811567 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1811573: Remove custom healthchecks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2020
@dtantsur
Copy link
Member Author

dtantsur commented Mar 9, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 9, 2020
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Bugzilla bug 1811573, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1811567 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1811567 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 9, 2020
@dtantsur
Copy link
Member Author

dtantsur commented Mar 9, 2020

/retest

1 similar comment
@elfosardo
Copy link

/retest

@elfosardo
Copy link

/cherry-pick-approved

@elfosardo
Copy link

/retest

@elfosardo
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit fd29cc0 into openshift:release-4.4 Mar 10, 2020
@openshift-ci-robot
Copy link

@dtantsur: All pull requests linked via external trackers have merged. Bugzilla bug 1811573 has been moved to the MODIFIED state.

In response to this:

Bug 1811573: Remove custom healthchecks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants