virtmedia fixes #69
virtmedia fixes #69
Conversation
We don't have swift in metal3, use httpd server instead.
The one installed by grub2-efi-x64 can't find the grub.cnf in the iso ironic creates.
openshift-ci-robot
added
the
approved
| dd bs=1024 count=3200 if=/dev/zero of=esp.img && \ | ||
| mkfs.msdos -F 12 -n 'ESP_IMAGE' ./esp.img && \ | ||
| mmd -i esp.img EFI && \ | ||
| mmd -i esp.img EFI/BOOT && \ | ||
| grub2-mkimage -C xz -O x86_64-efi -p /boot/grub -o /tmp/grubx64.efi boot linux search normal configfile part_gpt btrfs ext2 fat iso9660 loopback test keystatus gfxmenu regexp probe efi_gop efi_uga all_video gfxterm font scsi echo read ls cat png jpeg halt reboot && \ |
There was a problem hiding this comment.
Note: this line in the upstream patch included the linuxefi module, this appears to not be needed in RHEL8 (or available)
There was a problem hiding this comment.
the linuxefi is not needed in general, it's long gone from upstream grub and it was kept just for compatibility with old versions, please also see metal3-io#128
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-metal-ipi |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Two patches from upstream image for virtmedia install