Disable sensor data collection #80
Conversation
Sensor data collection was intended for an earlier use of the ironic-image and resulting ironic container image in order to supply data to prometheus about hardware that has not yet been deployed upon. Since the deicsion was made not to leverage the data, it seems pointless to collect sensor data. As such, disable sensor data collection.
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, juliakreger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Do we want to make this change upstream, too? |
|
@dhellmann I kind of want to say no. Openshift specific usage is not going to leverage this. Upstream could one day use it. |
I'm not even sure anyone else is aware this feature exists, but you may be right. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Add set -e to all the entrypoint scripts
I've seen some situations where mariadb is not up soon enough for the dbsync, despite the 10 retries done inside ironic-dbsync. In this situation we start the ironic services anyway and since openshift#80 got reverted, we can't rely on pod/container restart to handle this, so lets retry inside the script logging a warning instead.
I've seen some situations where mariadb is not up soon enough for the dbsync, despite the 10 retries done inside ironic-dbsync. In this situation we start the ironic services anyway and since openshift#80 got reverted, we can't rely on pod/container restart to handle this, so lets retry inside the script logging a warning instead.
Sensor data collection was intended for an earlier use of
the ironic-image and resulting ironic container image in order
to supply data to prometheus about hardware that has not yet
been deployed upon. Since the deicsion was made not to leverage
the data, it seems pointless to collect sensor data.
As such, disable sensor data collection.