Update inspection configuration to enable fast-track #83
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/hold WIP to see CI results |
openshift-ci-robot
added
approved
Add ipa-api-url to inspector.ipxe and extra params in ironic.conf. Without it ironic will never learn that the ramdisk has been booted for inspection, requiring a reboot despite fast-track enabled. NOTE: we need to configure everything in two places because there are two inspection paths: discovery-style (via inspector.ipxe) and managed (the same way as cleaning and deployment work). Conflicts: inspector.ipxe Backport of metal3-io#163
hardys
force-pushed
the
openshift_fast_track
branch
from
266d147
to
3404851
Compare
|
/retitle Update inspection configuration to enable fast-track |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
openshift-ci-robot
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@dtantsur please can you review - there was a conflict on inspector.ipxe to check but otherwise a clean backport |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Could you add this commit to the PR? metal3-io#173 It fixes a problem here. |
|
/lgtm cancel |
We should only set power_off to false when fast_track is true. Also do not pass ipa-api-url if fast-track is disabled, otherwise IPA will think it's enabled and try lookup/heartbeat. Cherry-picked-from: metal3-io#173
Done, thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Revert "Add set -e to all the entrypoint scripts"
Add ipa-api-url to inspector.ipxe and extra params in ironic.conf.
Without it ironic will never learn that the ramdisk has been booted
for inspection, requiring a reboot despite fast-track enabled.
NOTE: we need to configure everything in two places because there are
two inspection paths: discovery-style (via inspector.ipxe) and managed
(the same way as cleaning and deployment work).
Backport of metal3-io#163 and metal3-io#173