Change endpoint URL recording for ironic 15.x #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
elfosardo
approved these changes
Jul 2, 2020
|
We seem to have a version of this in the upstream image, I guess we can't just cherry-pick it as it also removes api_url ? |
dtantsur
requested changes
Jul 2, 2020
dtantsur
reviewed
Jul 13, 2020
elfosardo
requested changes
Jul 17, 2020
There was a problem hiding this comment.
let's do as suggested by @derekhiggins and @dtantsur and cherry pick the upstream change ?
api_url has been deprecated, changing it for endpoint_override
dtantsur
force-pushed
the
openshift-prepare-for-ironic-15
branch
from
50afc33
to
c75bf76
Compare
dtantsur
approved these changes
Jul 21, 2020
elfosardo
approved these changes
Jul 21, 2020
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo, hardys, juliakreger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andfasano
pushed a commit
to andfasano/ironic-image
that referenced
this pull request
Nov 18, 2020
Disable listening for DNS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ironic 15.x removes a long deprecated [conductor]api_url
parameter. This patch prepares for that by setting the correct
parameter, and notes in-line the old parameter that can be
eventually removed once OpenShift begins consuming ironic 15.x.