-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build stage runs for a long time, marked successful after build fails #41
Comments
/cc @sspeiche |
is that the entirety of your jenkinsfile? i know i saw the same issue where a failing build step didn't immediately fail the entire pipeline, but i didn't see it hang for 5 minutes, it just completed the pipeline. Any idea what it was doing for the rest of the time? |
No, I have a deploy step after the build completes.
1.0.10 now. I can try 1.0.12. |
Yeah, the fix went into 1.0.11; if for some reason 1.0.12 does not solve it for you, I'll dive into how to debug. |
@gabemontero I think there are two problems here
1.0.12 solves (1), but not (2). The stage in the pipeline is successful even though the s2i build failed @bparees I was able to reproduce this with your pipeline templates by editing the bc/ruby-sample-build to use a bogus source URL |
@spadgett can you show me the console output? |
Jenkins console log:
All pipeline stages are succesful: Here is my Jenkinsfile (from @bparees pipeline template openshift/origin#8973) node('agent') {
stage 'build'
def builder = new com.openshift.jenkins.plugins.pipeline.OpenShiftBuilder("", "ruby-sample-build", "pipelineproject", "", "", "", "", "true", "", "")
step builder
stage 'deploy'
def deployer = new com.openshift.jenkins.plugins.pipeline.OpenShiftDeployer("","frontend","pipelineproject","","")
step deployer
} |
so the issue is either:
i don't know enough about either to speculate where the problem actually is. |
@spadgett thanks, I believe I know what is going on now. Right after the message
openshift-pipeline plugin returns However, in the very similar, yet different, class hierarchy for the pipeline stuff, the same api has a I'll use this issue to add that logic (separate from the DSL stuff). |
but apparently @gabemontero does :) |
@spadgett try installing this version of the plugin |
Here is the associated commit |
Works great. Thanks @gabemontero
I'd suggest changing the message if possible. |
Cool deal. Changes to the message are possible - do you have a specific On Tue, May 24, 2016 at 1:56 PM, Sam Padgett notifications@github.com
|
I think just "ERROR: OpenShift build failed." or "ERROR: OpenShift deployment failed." etc. are more clear. |
OK, I went with our "meticulously" crafted "official" step titles :-) ... i.e.: ERROR: "Trigger OpenShift Build" failed Going ahead and marking this closed. |
ruby-sample-build-4 was kicked off by sample-pipeline-4. The s2i build failed after one second, but the pipeline stage ran for ~5 minutes.
Much later the pipeline stage was marked as successful even when the build failed.
Here is how I'm running the build from my Jenkinsfile
I can see the build was failed in the Jenkins log.
@gabemontero Will the DSL changes correctly mark the stage as failed when the build fails? https://trello.com/c/jOEuMkze
/cc @bparees @jwforres
The text was updated successfully, but these errors were encountered: