add jenkins pipeline example files #8973
Conversation
bparees
force-pushed
the
cicd_doc
branch
5 times, most recently
from
973887d
to
931279c
Compare
|
@csrwng ptal, primarily to ensure i've added this template to cluster-up correctly. |
|
The bindata and cluster up partt LGTM |
|
@gabemontero ptal |
| To walk through the example: | ||
| 1) Stand up an openshift cluster from origin master, installing the standard imagestreams to the openshift namespace: | ||
|
|
||
| https://github.com/openshift/origin |
There was a problem hiding this comment.
since your are talking specifically about the imagestreams, should this URL include examples/image-streams/ at the end of it, possibly list the two json files as well?
There was a problem hiding this comment.
well i was more trying to point them to origin since the step is "stand up origin" but i can add a link to the imagestreams as well.
There was a problem hiding this comment.
(ultimately i'll probably want to update this doc to instruct people to use the new cluster up command which would include the imagestreams+template automatically)
|
Couple of minor comments / questions, otherwise GTM |
bparees
force-pushed
the
cicd_doc
branch
2 times, most recently
from
14d2f50
to
41b10c4
Compare
|
@csrwng fyi i found i couldn't specify a filename in the go-bindata path, it ended up adding it with a repeated name (jekinstemplatejsonjenkinstemplatejson" in the method name) which ultimately lead to cluster up failing when i ran it. Not sure if we have unit tests for cluster up that would have caught that? but anyway i'm now adding everything in the dir, but not installing the other files during cluster up. |
|
|
||
| # Jenkins master template: | ||
| $ oc create -f https://goo.gl/YROngT | ||
| $ oc create -f $ oc create -f https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/master-slave/jenkins-master-template.json |
There was a problem hiding this comment.
Looks like there's a duplicate $ oc create -f on this line.
There was a problem hiding this comment.
one is the slave file and one is the master file.
There was a problem hiding this comment.
sure, but the result is:
**$ oc create -f $ oc create -f** https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/master-slave/jenkins-master-template.json
|
@bparees thanks, I will add a unit tests to cluster up to catch problems with the bindata files. |
bparees
force-pushed
the
cicd_doc
branch
2 times, most recently
from
63eb999
to
8a5e60b
Compare
|
ok i think this is all good now, @spadgett can you give it a once over since you're pretty familiar w/ the steps at this point? |
|
|
||
| 5) View/Manage jenkins | ||
| Once the jenkins pod is running, determine the jenkins service ip ("oc get svc") and go to it in your browser on port 80. Do not confuse | ||
| it with the jenkins-jnlp service. |
There was a problem hiding this comment.
Are the instructions to find the IP address correct using oc cluster up? I'd expect the default Jenkins route to work.
There was a problem hiding this comment.
well they're still correct in that it'll work that way, but yes presumably you could access it via the route as well. I don't really like relying on the router because getting it (and DNS) working tend to be problem areas for people, though admittedly that's part of what cluster up is supposed to solve.
|
@spadgett comments addressed. |
| utilize pods run on OpenShift as Jenkins slaves. | ||
|
|
||
| To walk through the example: | ||
| 1) Stand up an openshift cluster from origin master, installing the standard imagestreams to the openshift namespace: |
There was a problem hiding this comment.
@bparees you need empty line before 1) otherwise markup will join it with previous line
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5984/) (Image: devenv-rhel7_4272) |
|
Evaluated for origin merge up to d22ba66 |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4019/) |
|
Evaluated for origin test up to d22ba66 |
No description provided.