Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2011815: UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods #1009

Conversation

rphillips
Copy link

Fixes an issue with filtering active pods.

Upstream Ref: kubernetes#105527

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

@rphillips: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 7, 2021
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@rphillips rphillips changed the title UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods Bug 2011815: UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods Oct 7, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

@rphillips: This pull request references Bugzilla bug 2011815, which is invalid:

  • expected dependent Bugzilla bug 2011513 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2011815: UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips rphillips force-pushed the fixes/filter_terminated_pods_openshift_4.9 branch from 61f609a to fcc1b87 Compare October 7, 2021 17:12
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@rphillips rphillips force-pushed the fixes/filter_terminated_pods_openshift_4.9 branch from fcc1b87 to fdd3710 Compare October 7, 2021 17:13
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 7, 2021
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

@rphillips rphillips force-pushed the fixes/filter_terminated_pods_openshift_4.9 branch from fdd3710 to d9c3e57 Compare October 7, 2021 17:57
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@rphillips rphillips changed the title Bug 2011815: UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods [release-4.9] Bug 2011815: UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods Oct 7, 2021
@rphillips rphillips force-pushed the fixes/filter_terminated_pods_openshift_4.9 branch from d9c3e57 to c4e9f18 Compare October 7, 2021 19:47
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@rphillips rphillips force-pushed the fixes/filter_terminated_pods_openshift_4.9 branch from c4e9f18 to 3a18f2b Compare October 7, 2021 20:50
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@rphillips rphillips force-pushed the fixes/filter_terminated_pods_openshift_4.9 branch from 3a18f2b to 97fea36 Compare October 7, 2021 21:27
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@rphillips
Copy link
Author

/retest-required

Succeeded pods should not be counted as running on restart.
@rphillips rphillips force-pushed the fixes/filter_terminated_pods_openshift_4.9 branch from 97fea36 to 4db44f2 Compare October 7, 2021 23:32
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@rphillips
Copy link
Author

/retest-required

@mrunalp mrunalp added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp mrunalp added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 8, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rphillips
Copy link
Author

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-csi-manila 552163c link false /test e2e-openstack-csi-manila
ci/prow/e2e-openstack-csi-cinder 552163c link false /test e2e-openstack-csi-cinder

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips
Copy link
Author

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 894a78b into openshift:release-4.9 Oct 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

@rphillips: All pull requests linked via external trackers have merged:

Bugzilla bug 2011815 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2011815: UPSTREAM: 105527: kubelet: do not arbitrarily create a podSyncStatus for finished pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants