OCPBUGS-8314: bump to k8s 1.23.17 #1497
Conversation
Co-authored-by: silenceper <silenceper@gmail.com>
Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
Fix the one path where boundNextDispatchLocked was not being called after modifying a queue. Also check for negative work in a request. These are motivated by kubernetes#112169 but I do not have a way to reproduce it and so can not check that these changes actually remove that symptom. But these changes are good anyway.
Currently, when kubelet will try to compress the logs to a .gz file, it will attempt to rename the archive before closing its file handles, which results in an error on Windows. This addresses the issue mentioned above.
For example, we have two filesystems, one is embedded into another:
/a/test # first filesystem with a directory "/a/test/b2"
/a/test/b2 # not auto mounted yet second filesystem, notice "/a/test/b2" is
# a new directory on this filesystem after this filesystem is mounted
For subpath mount "/a/test/b2", `openat("/a/test", "b2")` gets directory "b2" on the first
filesystem, then "mount -c" will use this wrong directory as source directory.
`fstatat("/a/test", "b2/")` forces triggering auto mount of second filesystem, so
`openat("/a/test", "b2")` gets correct source directory for "mount -c".
This fixes issue kubernetes#110818 (comment)
References:
1. https://man7.org/linux/man-pages/man2/openat.2.html
If pathname refers to an automount point that has not yet
been triggered, so no other filesystem is mounted on it,
then the call returns a file descriptor referring to the
automount directory without triggering a mount.
2. https://man7.org/linux/man-pages/man2/open_by_handle_at.2.html
name_to_handle_at() does not trigger a mount when the final
component of the pathname is an automount point. When a
filesystem supports both file handles and automount points, a
name_to_handle_at() call on an automount point will return with
error EOVERFLOW without having increased handle_bytes. This can
happen since Linux 4.13 with NFS when accessing a directory which
is on a separate filesystem on the server. In this case, the
automount can be triggered by adding a "/" to the end of the
pathname.
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
[release-1.23] CHANGELOG-1.23: Add missing changes for 1.23.12
…ck-of-#112557-upstream-release-1.23 Automated cherry pick of kubernetes#112557: Fix list estimator for lists that are executed as gets
…pick-of-#111428-upstream-release-1.23 Automated cherry pick of kubernetes#111428: Skip "instance not found" error for LB backend address pools
…k-of-#112403-upstream-release-1.23 Automated cherry pick of kubernetes#112403: Call SetupDevice only if Volume is not globally Mounted
…-pick-of-#110973-upstream-release-1.23 Automated cherry pick of kubernetes#110973: Make sure auto-mounted subpath mount source is already
…ck-of-#109114-upstream-release-1.23-1661519732 client-go: make retry in Request thread safe
…k-of-#111549-upstream-release-1.23 Automated cherry pick of kubernetes#111549: Fixes kubelet log compression on Windows
Change-Id: I8a860d336060848fe71b46991ac148ff704f7b60
…changed. Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
Cherry pick kubernetes#112607 Make mount ref search more robust
…rry-pick-of-#112785-upstream-release-1.23 Automated cherry pick of kubernetes#112785: service update event should be triggered when appProtocol in
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-fips, ci/prow/k8s-e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerpeter1, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test e2e-azure-upgrade |
1 similar comment
|
/test e2e-azure-upgrade |
|
/retest-required |
|
/override ci/prow/verify-commits /test e2e-gcp |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test e2e-aws-cgroupsv2 |
|
/test e2e-gcp |
|
@jerpeter1: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-gcp |
|
/override ci/prow/e2e-aws-cgroupsv2 |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-cgroupsv2 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
merged commit 16bcd69
into
openshift:release-4.10
|
@jerpeter1: Jira Issue OCPBUGS-8314: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-8314 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-pod-container-v4.10.0-202305011254.p0.g16bcd69.assembly.stream for distgit openshift-enterprise-pod. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-hyperkube-container-v4.10.0-202305011254.p0.g16bcd69.assembly.stream for distgit openshift-enterprise-hyperkube. |
No description provided.