Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15726: Revert "temporarily disable oc explain tests until openapi/v3 is working" #28155

Merged
merged 2 commits into from Aug 11, 2023
Merged

OCPBUGS-15726: Revert "temporarily disable oc explain tests until openapi/v3 is working" #28155

merged 2 commits into from Aug 11, 2023

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Aug 8, 2023 •
edited

@openshift-ci openshift-ci bot requested review from csrwng and dtantsur August 8, 2023 21:03
@atiratree
Copy link
Member Author

/hold
until openshift/kubernetes#1654 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2023
@atiratree atiratree changed the title Revert "temporarily disable oc explain tests until openapi/v3 is working" OCPBUGS-15726: Revert "temporarily disable oc explain tests until openapi/v3 is working" Aug 8, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 8, 2023
@openshift-ci-robot
Copy link

@atiratree: This pull request references Jira Issue OCPBUGS-15726, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit 003c72d.

These explain tests should pass after openshift/kubernetes#1654 merges

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atiratree
Copy link
Member Author

/retest

1 similar comment
@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

tests failed for ImageTag due to non conforming spec+status: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/28155/pull-ci-openshift-origin-master-e2e-gcp-ovn/1689614934851194880
Added a commit that should fix that: 8022731

@atiratree
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@atiratree
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2023
@openshift-ci-robot
Copy link

@atiratree: This pull request references Jira Issue OCPBUGS-15726, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

This reverts commit 003c72d.

These explain tests should pass after openshift/kubernetes#1654 merges

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial 8022731 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-openstack-ovn 8022731 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3546720 into openshift:master Aug 11, 2023
21 of 23 checks passed
@openshift-ci-robot
Copy link

@atiratree: Jira Issue OCPBUGS-15726: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-15726 has not been moved to the MODIFIED state.

In response to this:

This reverts commit 003c72d.

These explain tests should pass after openshift/kubernetes#1654 merges

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 12, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@dtantsur dtantsur Awaiting requested review from dtantsur

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

Assignees

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atiratree @openshift-ci-robot @ardaguclu @soltysh @openshift-merge-robot