OCPBUGS-15726: add tests for openapi v3 #28129
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@atiratree: This pull request references Jira Issue OCPBUGS-15726, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-bug
- test that merged openapi v3 discovery has partial URLs with a hash/etag - test groups that are both served by CRDs and external apiservers (eg openshift-apiserver). Like authorization.openshift.io that should be merged from both of these sources
atiratree
force-pushed
the
openapi-v3-delegation
branch
from
be45b52
to
e6b443e
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
| transport, err := rest.TransportFor(oc.AdminConfig()) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| req, err := http.NewRequest("GET", oc.AdminConfig().Host+"/openapi/v3", nil) |
There was a problem hiding this comment.
I wonder does this endpoint open in every openshift environment such as hypershift, microshift, etc.?
There was a problem hiding this comment.
I think it should, unless they disable the OpenAPIV3 feature somehow which is stable and locked to default already.
|
/retest |
1 similar comment
|
/retest |
|
@atiratree: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@atiratree: This pull request references Jira Issue OCPBUGS-15726, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/test ? |
|
@ardaguclu: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, atiratree, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/payload 4.14 nightly informing |
|
@atiratree: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
could not check if the user atiratree is trusted for pull request openshift/origin#28129: error checking atiratree for trust: failed to check if comment came from myself: fetching userdata from GitHub: Get "http://ghproxy/app": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue. |
|
/payload 4.14 nightly informing |
|
@ardaguclu: trigger 61 job(s) of type informing for the nightly release of OCP 4.14
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/31189840-383d-11ee-9111-ecf7a4ecb96e-0 |
|
/payload 4.14 nightly blocking |
|
@atiratree: trigger 8 job(s) of type blocking for the nightly release of OCP 4.14
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1eaea080-383f-11ee-9f7a-cd9181501654-0 |
|
/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-conformance periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-upgrade |
|
@atiratree: trigger 2 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0dc33270-3841-11ee-828f-4c45bf587cad-0 |
|
the hypershift test failed, but it seems like a flake. Nevertheless the hypershift job seems to run only hypershift related E2Es so this test will not even get run there: https://github.com/openshift/release/blob/6926af1f46ff43e67d0a92091479de91a2f042f6/ci-operator/step-registry/hypershift/aws/run-e2e/hypershift-aws-run-e2e-chain.yaml#L6 to make sure we are not missing anything and because it is Friday, I will run all the other payload jobs |
|
/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-serial periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-upgrade periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-sdn-bm |
|
@atiratree: trigger 6 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/db94d6f0-385e-11ee-97fd-3c7492def203-0 |
|
I am seeing some failures, but nothing related to our test. |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-robot
merged commit ff2c1fa
into
openshift:master
|
@atiratree: Jira Issue OCPBUGS-15726: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-15726 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tests should pass after the following merges
TODO: