Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-1892: Rebase 1.29.0 #1815

Merged
merged 2,276 commits into from Dec 21, 2023
Merged

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Dec 1, 2023

/hold

logicalhan and others added 30 commits November 1, 2023 15:00
Signed-off-by: James Sturtevant <jstur@microsoft.com>
update docs for v1.29 release (note this must be committed after code freeze)
wait.PollUntilContextCancel immediately executes condition once
Add a test that checks if the CRB (kubeadm:cluster-admins)
used for binding admin.conf file users (part of the
kubeadm:cluster-admins Group) to the "cluster-admins"
ClusterRole exists in kubeadm clusters.

It does that only for versions newer than the version
when this feature was added.
…dex-load-test

Benchmark job with backoff limit per index
…conf

test/e2e_kubeadm: add test for the kubeadm:cluster-admins CRB
Add conformance tests for flowcontrol APIs
…dex-remaining-e2e-test

Add remaining e2e tests for Job BackoffLimitPerIndex based on KEP
Add Azure to the list of providers that support accessing nodes
using SSH.
Note: This will require a follow up PR adding the required
environment variables, AZURE_SSH_KEY, KUBE_SSH_BASTION to the test
configuration.
CEL

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
…k-test

Add multi-webhook integration test
…r_info_fix

[StructuredAuthn] Ensure empty fields of user object are accessible by CEL
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
kube-dns as an alternative DNS addon to CoreDNS hasn't been supported
since 1.22 when kubeadm's v1beta3 API was added.

Remove the related tests from the e2e_kubeadm test framework.
I am having difficulties convincing myself if this is better or worse.
I didn't implement this originally because I didn't want to store nodes that
we weren't sure we've configured. However: if EnsureLoadBalancer fails we
should retry the call from the service controller. Doing it like this might
save us one update call from the node controller side for calls which have
already started executing from the service controller's side...is this really
that expensive at this point though? Is it really that dangerous to not do
either, given that we retry failed calls? Ahhhhh!!! Opinions, please! Help, please!
Tal-or and others added 7 commits December 20, 2023 17:58
Kubelet should advertise the shared cpus as extedned resources.
This has the benefit of limiting the amount of containers
that can request an access to the shared cpus.

For more information see - openshift/enhancements#1396

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Adding a new mutation plugin that handles the following:

1. In case of `workload.openshift.io/enable-shared-cpus` request, it
   adds an annotation to hint runtime about the request. runtime
   is not aware of extended resources, hence we need the annotation.
2. It validates the pod's QoS class and return an error if it's not a
   guaranteed QoS class
3. It validates that no more than a single resource is being request.
4. It validates that the pod deployed in a namespace that has mixedcpus
   workloads allowed annotation.

For more information see - openshift/enhancements#1396

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Restore `migratedPlugins` entry for in-tree vSphere volumes and mark them
as migrated. Otherwise the CSI volume plugin ignores in-tree vSphere
volumes and they will never get attached / mounted by CSI migration.

The entry in `migratedPlugins` was incorrectly removed during
CSIMigrationvSphere feature gate removal.
@wallylewis
Copy link

/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-upgrade

Copy link

openshift-ci bot commented Dec 20, 2023

@wallylewis: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/957b0f00-9f64-11ee-955e-6673503d76c8-0

@openshift-ci-robot
Copy link

@soltysh: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@soltysh
Copy link
Member Author

soltysh commented Dec 20, 2023

/hold cancel
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Dec 20, 2023
@wallylewis
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
Copy link

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, wallylewis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member Author

soltysh commented Dec 20, 2023

/test unit

1 similar comment
@soltysh
Copy link
Member Author

soltysh commented Dec 20, 2023

/test unit

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7aa0a74 and 2 for PR HEAD 8676e3b in total

@soltysh
Copy link
Member Author

soltysh commented Dec 20, 2023

/override ci/prow/unit
that is a known problem with golang we're chasing elsewhere

Copy link

openshift-ci bot commented Dec 20, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/unit

In response to this:

/override ci/prow/unit
that is a known problem with golang we're chasing elsewhere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallylewis
Copy link

/retest-required

Copy link

openshift-ci bot commented Dec 21, 2023

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 7f79e03 link false /test e2e-azure
ci/prow/e2e-agnostic-ovn-cmd 8676e3b link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b0d609f into openshift:master Dec 21, 2023
22 of 23 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202312210731.p0.gb0d609f.assembly.stream for distgit openshift-enterprise-pod.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-hyperkube-container-v4.16.0-202312210731.p0.gb0d609f.assembly.stream for distgit openshift-enterprise-hyperkube.
All builds following this will include this PR.

@soltysh soltysh deleted the rebase-1.29.0 branch December 21, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet