Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32296: Bump K8s api to 1.29.4 #1947

Merged
merged 33 commits into from Apr 20, 2024

Conversation

sairameshv
Copy link
Member

/assign @soltysh

thockin and others added 30 commits January 10, 2024 12:19
…romStorageWithoutResourceVersion feature gate to allow serving watch from storage.
…acher package.

It turns out that kube has a custom timeout for tests of 3 minutes.
The tests in the cacher package are utilizing nearly the
entire time and are being terminated, resulting in failing jobs.

Before the change, the TestWatchSemantics took ~43s to run. With this simple change, it now takes ~18s.

When we created the tests, we didn't measure the running time and assumed that waiting 1 second on a watch channel
to make sure no more events are received was sufficient.
This PR decreases the waiting time to 300 milliseconds.
Modern computers can perform many tasks within that time.
In addition to that, the tests are serial in nature, meaning that there is no other
actor that could add items to the database, which could result in receiving new items.

After the change the total running time decreased by 17%.
Before the tests needed ~176s after they need ~146s.
The changes also improved TestWatchSemanticInitialEventsExtended.
…from-etcd-1.29

Cherry-pick of kubernetes#120897 kubernetes#123935 kubernetes#123887 kubernetes#123994: Serve watch without resourceVersion from cache and introduce a WatchFromStorageWithoutResourceVersion feature gate to allow serving watch from storage.
Co-authored-by: Davanum Srinivas <davanum@gmail.com>
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
…ck-of-#124124-upstream-release-1.29

Automated cherry pick of kubernetes#124124: fix panic with SIGSEGV in kubeadm certs check-expiration
…-pick-of-#124048-upstream-release-1.29

Automated cherry pick of kubernetes#124048: Use the right feature gate when updating uncertain volumes
…ick-of-#123570-upstream-release-1.29

Automated cherry pick of kubernetes#123570: Filter aggregated apiservice gv
…ick-of-#123873-kubernetes-release-1.29

Automated cherry pick of kubernetes#123873: retry policy creation for CRD type checking E2E test
…ck-of-#123598-upstream-release-1.29

Automated cherry pick of kubernetes#123598: Remotecommand test flake cleanup
…ss iptables / set-cap

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
[release-1.29] [go] Bump images, dependencies and versions to go 1.21.9 and distroless iptables and debian-base
…y-pick-of-#121894-origin-release-1.29

Automated cherry pick of kubernetes#121894: build: use -trimpath in non-DBG mode
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
…k-of-#124322-upstream-release-1.29

Automated cherry pick of kubernetes#124322: Add envFrom to serviceaccount admission plugin
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 18, 2024
@openshift-ci-robot
Copy link

@sairameshv: This pull request references Jira Issue OCPBUGS-32296, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/assign @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@sairameshv: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Apr 18, 2024
@flavianmissi
Copy link
Member

@sairameshv @soltysh can we also link this one to bug https://issues.redhat.com/browse/OCPBUGS-31716?

@sairameshv
Copy link
Member Author

@sairameshv @soltysh can we also link this one to bug https://issues.redhat.com/browse/OCPBUGS-31716?

Done !!

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Apr 19, 2024
@soltysh
Copy link
Member

soltysh commented Apr 19, 2024

/override ci/prow/unit
this is a known failure there

/retest-required

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 19, 2024
Copy link

openshift-ci bot commented Apr 19, 2024

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/unit

In response to this:

/override ci/prow/unit
this is a known failure there

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
Copy link

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sairameshv, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 60262d1 and 2 for PR HEAD 93a2209 in total

@soltysh
Copy link
Member

soltysh commented Apr 20, 2024

/test e2e-gcp

Copy link

openshift-ci bot commented Apr 20, 2024

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d9d4530 into openshift:master Apr 20, 2024
23 checks passed
@openshift-ci-robot
Copy link

@sairameshv: Jira Issue OCPBUGS-32296: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32296 has been moved to the MODIFIED state.

In response to this:

/assign @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202404201710.p0.gd9d4530.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.16.0-0.nightly-2024-04-21-123502

@sairameshv sairameshv deleted the bump-1.29.4 branch April 22, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet