-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: retry etcd errors #322
Conversation
/retest |
1 similar comment
/retest |
/refresh |
/retest |
/test gcp-upgrade |
@hexfusion: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp-upgrade |
1 similar comment
/test e2e-gcp-upgrade |
/retest |
need more data /test e2e-gcp-upgrade |
/retest |
FTR both upgrade jobs passed |
taking over the work, moving it to #327 |
I think I have an understanding of what's causing some of the tests to fail - rbac bootstrapping takes longer than the test timeout
This is the wait function in testserver.go:
I am experimenting with aggressively reducing the retry backoff delay here #327. The integration job passes with much smaller retry delay https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/327/pull-ci-openshift-kubernetes-master-integration/1301014246380802048 So the next steps are:
|
Think ugly. We can do this by having global to turn it off and on. |
If this significantly improves behavior on azure in 4.6, we can consider taking it upstream. It is authored to be lightweight to carry.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
closing in favor of #327 /close |
@tkashem: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This retries all non-mutating requests for etcd. This can be wasteful if things like RVs are outside the window, but it's easy to reason about at the moment and it has the effect of simply throttling the speed for the watcher or lister.
This retries only certain mutating request errors. The ones that I know mean "this action didn't do anything".