-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.6] UPSTREAM: 103666: test/e2e: Busybox image is not being templatized #867
[release-4.6] UPSTREAM: 103666: test/e2e: Busybox image is not being templatized #867
Conversation
@rvanderp3: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
cc: @sdodson |
@rvanderp3: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
42c9ebc
to
92c8e23
Compare
@rvanderp3: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rvanderp3 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@rvanderp3: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
All images used by e2e tests must use templates in order to allow relocation. In addition this is hitting Dockerhub which will be getting throttled soon.
92c8e23
to
0d4218b
Compare
@rvanderp3: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
@rvanderp3: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Test only change. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
All images used by e2e tests must use templates in order to allow relocation. This allows alternate locations for e2e test images to be specified. Specifically, this is a test only change that improves the ability of someone running e2e tests to move the busybox image elsewhere (not on dockerhub) as part of general image relocation.