[release-4.9] Bug 2002811: UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials

[openshift-cherrypick-robot]

This is an automated cherry-pick of #927

/assign sjenning

[openshift-ci-robot]

@openshift-cherrypick-robot: the contents of this pull request could be automatically validated.

The following commits are valid:

• 397461b|UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials: the upstream PR kubernetes/kubernetes#104314 has merged

[openshift-ci]

@openshift-cherrypick-robot: Bugzilla bug 2002808 has been cloned as Bugzilla bug 2002811. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2002811: UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials

In response to this:

[release-4.9] Bug 2002808: UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2002811, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2002808 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Bugzilla bug 2002808 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

[release-4.9] Bug 2002811: UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sjenning]

Upstream 1.22 pick kubernetes#104850

[JoelSpeed]

As this PR is solely containing changes within the staging directory, are we sure this will take effect? I'm guessing when we build our KCM it uses go mod replacement to build from the staging directories but I don't know that for certain. I guess approvers will know.

[soltysh]

/hold
Get upstream pick merged, or explicitly rejected. Only then we can re-consider this PR.

[sjenning]

@JoelSpeed the vendor k8s.io/cloud-provider points to staging https://github.com/openshift/kubernetes/blob/687a5bf/go.mod#L529

[sjenning]

@soltysh this has now merged upstream

[sjenning]

/retest

[soltysh]

@soltysh this has now merged upstream

The linked BZ is medium severity, in which case I'd delay that until we bump to next patch release, which is planned for later this week and we'll get it for free next week.

[sjenning]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@sjenning: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nee1esh]

/retest-required

[openshift-ci]

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-csi-manila	397461b	link	false	/test e2e-openstack-csi-manila
ci/prow/e2e-openstack-csi-cinder	397461b	link	false	/test e2e-openstack-csi-cinder

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sjenning]

@soltysh just a bump on this to make sure we pick it up this week. Thanks!

[sjenning]

#927 merged
/hold cancel

[soltysh]

we'll pick this in #1003
/hold

[sjenning]

@soltysh this change went in after 1.22.2 and thus will not be included in the rebase

[soltysh]

@soltysh this change went in after 1.22.2 and thus will not be included in the rebase

First of all, this is part of 1.22.2, see https://github.com/kubernetes/kubernetes/blob/v1.22.2/staging/src/k8s.io/legacy-cloud-providers/aws/aws.go your commit is the last one there.
Secondly, the bug associated with this pick is just medium, iow. it's not critical to skip the proper backport process, unless the bug's priority is wrong.
Lastly, I'm currently going through k8s bump PRs with hope to land them this week, so I will keep the hold until then.

[sjenning]

#985 has merged and included this

[sjenning]

/close

[openshift-ci]

@sjenning: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2002811. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

[release-4.9] Bug 2002811: UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.