image/reference: support parsing partial repo names #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
parse-partial-repo-name
branch
2 times, most recently
from
5cb5d19
to
e8f1a14
Compare
this is useful in mirroring contexts, where a set of images may be mirrored into the same registry, or into the same namespace of a target
ecordell
force-pushed
the
parse-partial-repo-name
branch
from
e8f1a14
to
670e819
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, ecordell, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.6 |
|
@estroz: new pull request created: #1198 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in mirroring contexts, where a set of images may be mirrored into the same registry, or into the same namespace of a target.
For example,
oc adm catalog mirrorallows you to mirror a catalog into a specific registry or location, so the destination for a mirror can belocalhost:5000orquay.ioorquay.io/my-namespaceordocker.io/my/nested/orgetc.Unlike
oc image mirror, the source is a large list of images instead of only one. Adding support for parsing partial repository names makes it easier to useTypedImageReferencesinoc adm catalog mirror