Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CRDs for openshift.io #185

Merged

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jan 28, 2019

Although we aim to consume directly from upstream repo, we are temporary mirroring upstream API under openshift.io https://github.com/openshift/cluster-api. This PR makes both available for a backward compatible migration

Although we aim to consume directly from upstream repo, we are temporary mirroring upstream API under openshift.io https://github.com/openshift/cluster-api. This PR makes both available for a backward compatible migration
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 28, 2019
@enxebre
Copy link
Member Author

enxebre commented Jan 28, 2019

cc @bison @frobware @ingvagabund

Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2019
@enxebre
Copy link
Member Author

enxebre commented Jan 28, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit e791b3d into openshift:master Jan 28, 2019
enxebre added a commit to enxebre/installer that referenced this pull request Feb 7, 2019
We are transitioning the cluster API types from k8s.io over a machine.openshift.io group.
https://github.com/openshift/cluster-api/tree/91fca585a85b163ddfd119fd09c128c9feadddca
Although this give us a necessary level of autonomy today, we aim to consolidate back with upstream once there's a release of the API stable enough
For reference:
Backward compatible changes on machine api operator
[openshift/machine-api-operator#185](openshift/machine-api-operator#185)
[openshift/machine-api-operator#188](openshift/machine-api-operator#188)
[openshift/machine-api-operator#191](openshift/machine-api-operator#191)
Libvirt actuator support for new group
openshift/cluster-api-provider-libvirt#111
enxebre added a commit to enxebre/installer that referenced this pull request Feb 7, 2019
We are transitioning the cluster API types from k8s.io over a machine.openshift.io group.
https://github.com/openshift/cluster-api/tree/91fca585a85b163ddfd119fd09c128c9feadddca
Although this give us a necessary level of autonomy today, we aim to consolidate back with upstream once there's a release of the API stable enough
For reference:
Backward compatible changes on machine api operator
[openshift/machine-api-operator#185](openshift/machine-api-operator#185)
[openshift/machine-api-operator#188](openshift/machine-api-operator#188)
[openshift/machine-api-operator#191](openshift/machine-api-operator#191)
Libvirt actuator support for new group
openshift/cluster-api-provider-libvirt#111
enxebre added a commit to enxebre/installer that referenced this pull request Feb 7, 2019
We are transitioning the cluster API types from k8s.io over a machine.openshift.io group.
https://github.com/openshift/cluster-api/tree/91fca585a85b163ddfd119fd09c128c9feadddca
Although this give us a necessary level of autonomy today, we aim to consolidate back with upstream once there's a release of the API stable enough
For reference:
Backward compatible changes on machine api operator
[openshift/machine-api-operator#185](openshift/machine-api-operator#185)
[openshift/machine-api-operator#188](openshift/machine-api-operator#188)
[openshift/machine-api-operator#191](openshift/machine-api-operator#191)
Libvirt actuator support for new group
openshift/cluster-api-provider-libvirt#111
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants