-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libvirt machine api #1204
Libvirt machine api #1204
Conversation
cc @bison |
cc24572
to
18e8eb1
Compare
18e8eb1
to
41fca86
Compare
/test launch-aws |
The only remaining places where |
We are transitioning the cluster API types from k8s.io over a machine.openshift.io group.
41fca86
to
ecabe6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
@enxebre: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/restest |
/retest |
Move libvirt machines from k8s.io into openshift.io
We are transitioning the cluster API types from k8s.io over a machine.openshift.io group.
https://github.com/openshift/cluster-api/tree/91fca585a85b163ddfd119fd09c128c9feadddca
Although this give us a necessary level of autonomy today, we aim to consolidate back with upstream once there's a release of the API stable enough
For reference:
Backward compatible changes on machine api operator
[openshift/machine-api-operator#185](openshift/machine-api-operator#185)
[openshift/machine-api-operator#188](openshift/machine-api-operator#188)
[openshift/machine-api-operator#191](openshift/machine-api-operator#191)
Libvirt actuator support for new group
openshift/cluster-api-provider-libvirt#111