add back controllers using latest provider image so using machine.openshift.io #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
/lgtm |
|
From the design point of view accepted. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test images |
This was referenced Feb 1, 2019
Closed
enxebre
added a commit
to enxebre/installer
that referenced
this pull request
Feb 7, 2019
We are transitioning the cluster API types from k8s.io over a machine.openshift.io group. https://github.com/openshift/cluster-api/tree/91fca585a85b163ddfd119fd09c128c9feadddca Although this give us a necessary level of autonomy today, we aim to consolidate back with upstream once there's a release of the API stable enough For reference: Backward compatible changes on machine api operator [openshift/machine-api-operator#185](openshift/machine-api-operator#185) [openshift/machine-api-operator#188](openshift/machine-api-operator#188) [openshift/machine-api-operator#191](openshift/machine-api-operator#191) Libvirt actuator support for new group openshift/cluster-api-provider-libvirt#111
enxebre
added a commit
to enxebre/installer
that referenced
this pull request
Feb 7, 2019
We are transitioning the cluster API types from k8s.io over a machine.openshift.io group. https://github.com/openshift/cluster-api/tree/91fca585a85b163ddfd119fd09c128c9feadddca Although this give us a necessary level of autonomy today, we aim to consolidate back with upstream once there's a release of the API stable enough For reference: Backward compatible changes on machine api operator [openshift/machine-api-operator#185](openshift/machine-api-operator#185) [openshift/machine-api-operator#188](openshift/machine-api-operator#188) [openshift/machine-api-operator#191](openshift/machine-api-operator#191) Libvirt actuator support for new group openshift/cluster-api-provider-libvirt#111
enxebre
added a commit
to enxebre/installer
that referenced
this pull request
Feb 7, 2019
We are transitioning the cluster API types from k8s.io over a machine.openshift.io group. https://github.com/openshift/cluster-api/tree/91fca585a85b163ddfd119fd09c128c9feadddca Although this give us a necessary level of autonomy today, we aim to consolidate back with upstream once there's a release of the API stable enough For reference: Backward compatible changes on machine api operator [openshift/machine-api-operator#185](openshift/machine-api-operator#185) [openshift/machine-api-operator#188](openshift/machine-api-operator#188) [openshift/machine-api-operator#191](openshift/machine-api-operator#191) Libvirt actuator support for new group openshift/cluster-api-provider-libvirt#111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster.k8s.ioandmachine.openshift.io