Bug 1999425: MaxUnhealthy should not be a string type #909

JoelSpeed · 2021-08-31T16:49:44Z

This field is an int or string and as such should not specify the type to be a string, this can cause errors in the CRD conversion when upgrading as we have changed the underlying type. Removing type: string should resolve these upgrade errors.

openshift-ci · 2021-08-31T16:53:54Z

@JoelSpeed: An error was encountered querying GitHub for users with public email (zhsun@redhat.com) for bug 1999425 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1999425: MaxUnhealthy should not be a string type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-08-31T17:03:36Z

/bugzilla refresh

openshift-ci · 2021-08-31T17:10:47Z

@JoelSpeed: An error was encountered querying GitHub for users with public email (zhsun@redhat.com) for bug 1999425 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-09-01T08:53:51Z

/retest

JoelSpeed · 2021-09-16T13:34:43Z

/bugzilla refresh

openshift-ci · 2021-09-16T13:35:48Z

@JoelSpeed: This pull request references Bugzilla bug 1999425, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-09-16T13:36:33Z

/bugzilla refresh

openshift-ci · 2021-09-16T13:36:38Z

@JoelSpeed: This pull request references Bugzilla bug 1999425, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko

makes sense to me
/approve

alexander-demicev

/approve

openshift-ci · 2021-09-16T14:06:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev, elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alexander-demichev,elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

elmiko · 2021-09-16T14:48:05Z

/lgtm

JoelSpeed · 2021-09-16T17:12:04Z

/retest

openshift-bot · 2021-09-16T19:27:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-16T19:50:44Z

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/goimports	`9c2103e`	link	`/test goimports`
ci/prow/golint	`9c2103e`	link	`/test golint`
ci/prow/e2e-openstack	`7f2124b`	link	`/test e2e-openstack`
ci/prow/e2e-gcp-operator	`7f2124b`	link	`/test e2e-gcp-operator`
ci/prow/e2e-libvirt	`7f2124b`	link	`/test e2e-libvirt`
ci/prow/e2e-vsphere-operator	`7f2124b`	link	`/test e2e-vsphere-operator`
ci/prow/e2e-aws-disruptive	`7f2124b`	link	`/test e2e-aws-disruptive`
ci/prow/e2e-azure-operator	`7f2124b`	link	`/test e2e-azure-operator`
ci/prow/e2e-vsphere	`7f2124b`	link	`/test e2e-vsphere`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-09-16T20:05:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-16T20:56:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-16T21:20:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-16T21:33:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-16T21:56:15Z

@JoelSpeed: All pull requests linked via external trackers have merged:

openshift/machine-api-operator#909

Bugzilla bug 1999425 has been moved to the MODIFIED state.

In response to this:

Bug 1999425: MaxUnhealthy should not be a string type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-09-17T08:02:23Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2021-09-17T08:03:05Z

@JoelSpeed: #909 failed to apply on top of branch "release-4.9":

Applying: Bump controller-tools to allow pattern on IntOrString
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump controller-tools to allow pattern on IntOrString
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from alexander-demicev and enxebre August 31, 2021 16:59

JoelSpeed force-pushed the mhc-max-unhealth-not-string branch from 5b9a7cd to 9c2103e Compare September 16, 2021 13:31

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2021

JoelSpeed added 2 commits September 16, 2021 14:33

Bump controller-tools to allow pattern on IntOrString

c3d6703

MaxUnhealthy should not be a string type

7f2124b

JoelSpeed force-pushed the mhc-max-unhealth-not-string branch from 9c2103e to 7f2124b Compare September 16, 2021 13:33

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2021

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 16, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 16, 2021

openshift-ci bot requested a review from sunzhaohua2 September 16, 2021 13:36

elmiko reviewed Sep 16, 2021

View reviewed changes

alexander-demicev approved these changes Sep 16, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021

openshift-ci bot assigned elmiko Sep 16, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021

openshift-merge-robot merged commit 2e5c150 into openshift:master Sep 16, 2021

JoelSpeed deleted the mhc-max-unhealth-not-string branch September 17, 2021 08:02

JoelSpeed mentioned this pull request Sep 17, 2021

Bug 2005242: MaxUnhealthy should not be a string type #919

Merged

JoelSpeed mentioned this pull request Nov 25, 2021

[release-4.8] Bug 2026562: MaxUnhealthy should not be a string type #962

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1999425: MaxUnhealthy should not be a string type #909

Bug 1999425: MaxUnhealthy should not be a string type #909

JoelSpeed commented Aug 31, 2021

openshift-ci bot commented Aug 31, 2021

JoelSpeed commented Aug 31, 2021

openshift-ci bot commented Aug 31, 2021

JoelSpeed commented Sep 1, 2021

JoelSpeed commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021

JoelSpeed commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021

elmiko left a comment

alexander-demicev left a comment

openshift-ci bot commented Sep 16, 2021

elmiko commented Sep 16, 2021

JoelSpeed commented Sep 16, 2021

openshift-bot commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021 •

edited

Loading

openshift-bot commented Sep 16, 2021

openshift-bot commented Sep 16, 2021

openshift-bot commented Sep 16, 2021

openshift-bot commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021

JoelSpeed commented Sep 17, 2021

openshift-cherrypick-robot commented Sep 17, 2021

Bug 1999425: MaxUnhealthy should not be a string type #909

Bug 1999425: MaxUnhealthy should not be a string type #909

Conversation

JoelSpeed commented Aug 31, 2021

openshift-ci bot commented Aug 31, 2021

JoelSpeed commented Aug 31, 2021

openshift-ci bot commented Aug 31, 2021

JoelSpeed commented Sep 1, 2021

JoelSpeed commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021

JoelSpeed commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021

elmiko left a comment

Choose a reason for hiding this comment

alexander-demicev left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 16, 2021

elmiko commented Sep 16, 2021

JoelSpeed commented Sep 16, 2021

openshift-bot commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021 • edited Loading

openshift-bot commented Sep 16, 2021

openshift-bot commented Sep 16, 2021

openshift-bot commented Sep 16, 2021

openshift-bot commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021

JoelSpeed commented Sep 17, 2021

openshift-cherrypick-robot commented Sep 17, 2021

openshift-ci bot commented Sep 16, 2021 •

edited

Loading