-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mco: If the platform is unrecognized, treat the platform as 'none' #340
mco: If the platform is unrecognized, treat the platform as 'none' #340
Conversation
/assign @abhinavdahiya Spitballed this a bit on slack today, I want to lay some foundations as I go and incrementally get components ready for this. |
/approve |
12d1bf8
to
ba41204
Compare
/retest |
I think this needs something like:
too |
/retest |
ba41204
to
bff47f3
Compare
I kept a similar structure and fixed the test. This highlighted something that the MCO API needs before GA - we need to be using consistent constants (the constants in https://github.com/openshift/api/blob/master/config/v1/types_infrastructure.go#L41 need to be used everywhere) @abhinavdahiya also in install config |
/retest |
@smarterclayton I opened an issue to make constants consistent in MCO: #342 |
bff47f3
to
323829f
Compare
I believe I found a bug, if Platform was empty on ControllerConfig before we would have looked at the root template dir incorrectly when trying to find templates (we weren't guarding some of the config generation with an empty string check, which this PR fixes). |
/retest |
1 similar comment
/retest |
Any other comments? |
In order to incrementally roll new platforms out across the project we must be able to provision platforms before all support is added. Components should treat an unrecognized platform as "None", performing the same function as they would in that scenario, and print a warning to the logs. This commit changes the generation so that a ControllerConfig with an empty platform returns an error instead of silently running. Ensure we test config on multiple platforms.
323829f
to
da21a3a
Compare
/retest |
Gentle ping ;) |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws |
Error in e2e-aws was ye olde:
|
Bug 1898745: actually set imagestreams in progress to false in imagestream event path
In order to incrementally roll new platforms out across the project
we must be able to provision platforms before all support is added.
Components should treat an unrecognized platform as "None", performing
the same function as they would in that scenario, and print a warning
to the logs.
Formalizing this requirement as we assess how future providers will
be added in openshift/installer#1112 (found in openshift/installer#1109)