Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.1] Bug 1726866: mcc: fix ignition validation to validate entire ign config #989

Merged
merged 1 commit into from
Aug 12, 2019
Merged

[release-4.1] Bug 1726866: mcc: fix ignition validation to validate entire ign config #989

merged 1 commit into from
Aug 12, 2019

Conversation

kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Jul 18, 2019 •
edited
Loading

also update existing unit tests to pass new validation

closes: BZ 1726866

Note: this is already fixed in master in PR #894 This PR is a backport for 4.1.z

cc: @runcom

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1726866: mcc: fix ignition validation to validate entire ign config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 18, 2019
@runcom
Copy link
Member

runcom commented Jul 18, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1726866: mcc: fix ignition validation to validate entire ign config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1726866: mcc: fix ignition validation to validate entire ign config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Member

runcom commented Jul 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2019
@kikisdeliveryservice
Copy link
Contributor Author

Need to update e2e here.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2019
@kikisdeliveryservice
Bug 1726866: mcc: fix ignition validation to validate entire ign config
2375eb2 
also update existing unit/e2e tests to pass new validation

closes: BZ 1726866
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2019
@kikisdeliveryservice
Copy link
Contributor Author

Ok e2e-aws-op is fixed now 😄

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2019
@runcom
Copy link
Member

runcom commented Jul 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eparis
Copy link
Member

eparis commented Jul 22, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 22, 2019
@openshift-ci-robot
Copy link
Contributor

@eparis: This pull request references an invalid Bugzilla bug:

  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 22, 2019
@eparis
Copy link
Member

eparis commented Jul 22, 2019

Looks like we are waiting for the 4.2 bug to be VERIFIED by QE. Will check again tomorrow.

@kikisdeliveryservice
Copy link
Contributor Author

Looks like we are waiting for the 4.2 bug to be VERIFIED by QE. Will check again tomorrow.

Thanks for the update @eparis !

@jwforres
Copy link
Member

still waiting on QE validation on 4.2, you may want to bump the BZ

@kikisdeliveryservice
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 12, 2019
@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references a valid Bugzilla bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 12, 2019
@kikisdeliveryservice kikisdeliveryservice changed the title Bug 1726866: mcc: fix ignition validation to validate entire ign config [release-4.1] Bug 1726866: mcc: fix ignition validation to validate entire ign config Aug 12, 2019
@derekwaynecarr
Copy link
Member

The 4.2 bug has been verified by QE. This is good to go in 4.1.z.

@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1509d99 into openshift:release-4.1 Aug 12, 2019
@kikisdeliveryservice kikisdeliveryservice deleted the release-4.1 branch September 3, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runcom runcom Awaiting requested review from runcom

Assignees

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kikisdeliveryservice @openshift-ci-robot @runcom @eparis @jwforres @derekwaynecarr @openshift-merge-robot