Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OSD branding #523

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

jewzaam
Copy link
Member

@jewzaam jewzaam commented Oct 21, 2020

@jewzaam
Copy link
Member Author

jewzaam commented Oct 21, 2020

/hold

Blocked by https://issues.redhat.com/browse/APPSRE-2631

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 21, 2020
@jewzaam
Copy link
Member Author

jewzaam commented Oct 23, 2020

APPSRE-2631 is done!

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2020
@jewzaam
Copy link
Member Author

jewzaam commented Oct 23, 2020

/hold

Err.. we're doing a SSS dance to get another change out, putting on hold until that's completed.
https://issues.redhat.com/browse/OSD-5566

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2020
README.md Outdated Show resolved Hide resolved
Co-authored-by: Christoph Blecker <admin@toph.ca>
@cblecker
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jewzaam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jewzaam
Copy link
Member Author

jewzaam commented Oct 27, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@jewzaam
Copy link
Member Author

jewzaam commented Oct 27, 2020

Technically not done w/ OSD-5566 but it's been hitting issues and is reverted to a state that's OK to try out this PR again.

@openshift-merge-robot openshift-merge-robot merged commit 674ff2d into openshift:master Oct 27, 2020
@jewzaam jewzaam deleted the osd-3122-c branch October 27, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants