Bug 1761921: Manifest lists can fail to mirror because dependent manifests are not uploaded #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
/retest |
|
We mirror the manifest list and blobs, but not the sub manifests. Correct that by registering those with the plan. We must then upload dependent manifests first, since the registry will not allow partial manifest lists.
smarterclayton
force-pushed
the
mirror_manifest_list
branch
from
6d950a0
to
7f23c32
Compare
openshift-ci-robot
added
size/L
|
Updated with ordering fixes |
|
/retest |
|
/test e2e-cmd |
|
Success! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
I will add origin mirroring e2e tests for this after (we have a few new tests to be created) |
smarterclayton
changed the title
|
@smarterclayton: All pull requests linked via external trackers have merged. Bugzilla bug 1761921 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.2 |
|
@smarterclayton: new pull request created: #128 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tbielawa
added a commit
to tbielawa/doozer
that referenced
this pull request
Oct 18, 2019
tbielawa
added a commit
to tbielawa/doozer
that referenced
this pull request
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mirror the manifest list and blobs, but not the sub manifests. Correct that by registering those with the plan.
Without this change mirroring a manifest list and
--filter-by-os=.*fails with 'manifest invalid' due to the sub manifest not being copied (you can't push a manifest list unless all manifests are found).