Add profiling functionality and flags in oc #1516
Conversation
To preserve the feature parity between oc and kubectl, this commit takes the profiling functionality in kubectl into the oc.
|
/cc @atiratree |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
/retest-required |
|
/retest |
|
After thinking on this, I think there is no need for a pre-merge testing since the feature is straightforward. What do you think @atiratree ? |
| flags.StringVar(&profileOutput, "profile-output", "profile.pprof", "Name of the file to write the profile to") | ||
| } | ||
|
|
||
| func initProfiling() error { |
There was a problem hiding this comment.
Would be great if we could import these from kubectl. I suppose we can copy for now, as it does not seem there are planned changes to these in the future
|
I agree, the feature looks straightforward |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, atiratree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
To preserve the feature parity between oc and kubectl, this commit takes the profiling functionality in kubectl into the oc
as detected by @atiratree in #1420 (comment)