Bug 1774318: use a fips compliant oc new-app example with the new-project message #170
Conversation
|
@gabemontero: This pull request references Bugzilla bug 1774318, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
assign @soltysh @openshift/openshift-team-developer-experience FYI |
|
/assign @soltysh |
|
setup flake /test e2e-aws |
| @@ -57,7 +57,7 @@ const ( | |||
| requestProjectNewAppOutput = ` | |||
| You can add applications to this project with the 'new-app' command. For example, try: | |||
|
|
|||
| %[1]s new-app django-psql-example | |||
| %[1]s new-app ruby~https://github.com/sclorg/ruby-ex.git | |||
There was a problem hiding this comment.
@gabemontero does the rails ephemeral template still work? rails-postgresql-example
There was a problem hiding this comment.
it wasn't in the "fips approved" list @adambkaplan and ATM I have not idea how to set up a fips env to try it out.
I'll ask in the bug.
There was a problem hiding this comment.
So it is 10 months later, and with https://bugzilla.redhat.com/show_bug.cgi?id=1866597
turns out we should have gone with your suggestion @adambkaplan :-)
Revisiting the BZ for this PR, I never did get an answer to my question in https://bugzilla.redhat.com/show_bug.cgi?id=1774318#c2 on fips approval for rails-postgresql-example
Upon review, ruby/rails components are the same for both our official template and the upstream repo wrt FIPS.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1774318 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.