Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabemontero does the rails ephemeral template still work?
rails-postgresql-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't in the "fips approved" list @adambkaplan and ATM I have not idea how to set up a fips env to try it out.
I'll ask in the bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it is 10 months later, and with https://bugzilla.redhat.com/show_bug.cgi?id=1866597
turns out we should have gone with your suggestion @adambkaplan :-)
Revisiting the BZ for this PR, I never did get an answer to my question in https://bugzilla.redhat.com/show_bug.cgi?id=1774318#c2 on fips approval for
rails-postgresql-example
Upon review, ruby/rails components are the same for both our official template and the upstream repo wrt FIPS.