Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1774318: use a fips compliant oc new-app example with the new-project message #170

Merged
merged 1 commit into from Nov 25, 2019
Merged

Bug 1774318: use a fips compliant oc new-app example with the new-project message #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cli/requestproject/request_project.go
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@ const (
requestProjectNewAppOutput = `
You can add applications to this project with the 'new-app' command. For example, try:

%[1]s new-app django-psql-example
%[1]s new-app ruby~https://github.com/sclorg/ruby-ex.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabemontero does the rails ephemeral template still work? rails-postgresql-example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't in the "fips approved" list @adambkaplan and ATM I have not idea how to set up a fips env to try it out.

I'll ask in the bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is 10 months later, and with https://bugzilla.redhat.com/show_bug.cgi?id=1866597
turns out we should have gone with your suggestion @adambkaplan :-)

Revisiting the BZ for this PR, I never did get an answer to my question in https://bugzilla.redhat.com/show_bug.cgi?id=1774318#c2 on fips approval for rails-postgresql-example

Upon review, ruby/rails components are the same for both our official template and the upstream repo wrt FIPS.


to build a new example application in Python. Or use kubectl to deploy a simple Kubernetes application:

Expand Down