Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1826533: pkg/cli/admin/upgrade: Warn when --allow-explicit-upgrade let you through #388

Merged

Conversation

wking
Copy link
Member

@wking wking commented Apr 16, 2020

To raise awareness that users are initiating an update which was not recommended by their configured Cincinnati upstream, so they are on the hook for validating its stability.

…ough

To raise awareness that users are initiating an update which was not
recommended by their configured Cincinnati upstream, so they are on
the hook for validating its stability.
@wking
Copy link
Member Author

wking commented Apr 16, 2020

images:

Job cannot be started: pods "f35d62ae-8021-11ea-9883-0a58ac10fbe1" already exists

/retest

@wking wking changed the title pkg/cli/admin/upgrade: Warn when --allow-explicit-upgrade let you through Bug 1826533: pkg/cli/admin/upgrade: Warn when --allow-explicit-upgrade let you through Apr 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 21, 2020
@openshift-ci-robot
Copy link

@wking: This pull request references Bugzilla bug 1826533, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1826533: pkg/cli/admin/upgrade: Warn when --allow-explicit-upgrade let you through

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Apr 21, 2020

/retest

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit ae3e321 into openshift:master Apr 22, 2020
@openshift-ci-robot
Copy link

@wking: Some pull requests linked via external trackers have merged: openshift/oc#387, openshift/oc#388. The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1826533: pkg/cli/admin/upgrade: Warn when --allow-explicit-upgrade let you through

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants