Bug 1826533: pkg/cli/admin/upgrade: Warn when --force is used #387
Conversation
Also soften "operator blocking upgrades" to the more generic "update precondition failures", because the cluster-version operator may learn about other preconditions with time. The warning is intended to raise awareness about --force being an "I've exhausted all other options and performed a bunch of undocumented manual verification" safety valve, and not something that anyone should be doing frequently.
/retest |
/retest |
|
Same e2e-cmd error again. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
wking
changed the title
openshift-ci-robot
added
the
bugzilla/severity-low
|
@wking: This pull request references Bugzilla bug 1826533, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: An error was encountered searching for bug 1826533 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We've been warning folks not to use this since at least 7a5d837 (pkg/cli/admin/upgrade: Warn when --force is used, 2020-04-16, openshift#387). But folks are still tempted to use it sometimes. To protect folks from the temptation, drop the option. Folks who are willing to take on all the 'force: true' risk (like QE testing unsigned CI builds) can use 'oc patch ...' to update ClusterVersion's spec more directly.
Also soften "operator blocking upgrades" to the more generic "update precondition failures", because the cluster-version operator may learn about other preconditions with time. The warning is intended to raise awareness about
--forcebeing an "I've exhausted all other options and performed a bunch of undocumented manual verification" safety valve, and not something that anyone should be doing frequently.