Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to generate ImageContentSourcePolicy scoped to a registry #485

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Add option to generate ImageContentSourcePolicy scoped to a registry #485

merged 1 commit into from
Aug 1, 2020

Conversation

sacharya
Copy link
Contributor

@sacharya sacharya commented Jul 6, 2020

This enhancement adds --icsp-scope flag to oc adm catalog mirror. Scopes can be registry or
repository. Defaults to repository, which is the existing behavior. Widening the mirror
to registry scope in the icsp file minimizes the number of times the cluster needs to
reboot its nodes..

Implements openshift/enhancements#374

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@ecordell
Copy link
Contributor

This looks good to me - I think you need to run the codegen for the bash/zsh completions to pass the verification.

@sacharya
Copy link
Contributor Author

/test e2e-cmd

@sacharya
Copy link
Contributor Author

/retest

@mhrivnak
Copy link
Member

@ecordell is there anything else that this needs in order to merge before feature freeze?

@sacharya
Copy link
Contributor Author

/assign @mfojtik

tnozicka
tnozicka reviewed Jul 29, 2020
View reviewed changes
pkg/cli/admin/catalog/mirror.go Outdated Show resolved Hide resolved
pkg/cli/admin/catalog/mirror.go Show resolved Hide resolved
pkg/cli/admin/catalog/mirror.go Outdated Show resolved Hide resolved
pkg/cli/admin/catalog/mirror.go Outdated Show resolved Hide resolved
@tnozicka
Copy link
Contributor

/assign

@sacharya
Copy link
Contributor Author

/test e2e-aws

@sacharya
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor

/approve
with the nit about the default locations

leaving lgmt to service catalog owners

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@sacharya
Add option to generate ImageContentSourcePolicy scoped to a registry
091f6e9 
This enhancement adds --icsp-scope flag to `oc adm catalog mirror`. Scopes can be registry or
repository. Defaults to repository, which is the existing behavior. Widening the mirror
to registry scope in the icsp file minimizes the number of times the cluster needs to
reboot its nodes..

Implements openshift/enhancements#374
@ecordell
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, sacharya, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sacharya
Copy link
Contributor Author

/retest

@mhrivnak
Copy link
Member

Tests are failing for reasons unrelated to this change. For example:

error: uploading the source layer sha256:e7021e0589e97471d99c4265b7c8e64da328e48f116b5f260353b2e0a2adb373 failed: unable to upload layer sha256:e7021e0589e97471d99c4265b7c8e64da328e48f116b5f260353b2e0a2adb373 to destination repository: received unexpected HTTP status: 504 Gateway Time-out

@mhrivnak
Copy link
Member

/retest

1 similar comment
@mhrivnak
Copy link
Member

/retest

@sacharya
Copy link
Contributor Author

/test e2e-aws

@mhrivnak
Copy link
Member

@tnozicka @ecordell what do you think about manually merging this before feature freeze today if we can't get this final test to run? Or is there some other process to go through when the test infra is broken?

@sacharya
Copy link
Contributor Author

/retest

@sacharya
Copy link
Contributor Author

sacharya commented Aug 1, 2020

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9cc7d77 into openshift:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell left review comments

@tnozicka tnozicka tnozicka left review comments

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mfojtik mfojtik

@ecordell ecordell

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sacharya @ecordell @mhrivnak @tnozicka @openshift-ci-robot @openshift-bot @mfojtik @openshift-merge-robot