Bug 1850931: 'oc image mirror' Add warning when mirroring SchemaVersion:1 images #493
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@sallyom: This pull request references Bugzilla bug 1850931, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
sallyom
force-pushed
the
bz1850931
branch
2 times, most recently
from
7fe2c67
to
61d8dc4
Compare
|
@sallyom: This pull request references Bugzilla bug 1850931, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/cli/image/mirror/mirror.go
Outdated
| @@ -735,6 +735,9 @@ func copyManifestToTags( | |||
| for _, desc := range srcManifest.References() { | |||
| plan.parent.parent.AssociateBlob(desc.Digest, plan.parent.name) | |||
| } | |||
| if srcDigest != toDigest { | |||
| fmt.Fprintf(out, "warning: Digests are not preserved with schema version 1 images. Support for schema version 1 images will be removed in a future release.\n") | |||
There was a problem hiding this comment.
Wire errout and use that, from what I'm grepping through our commands we tend to warn through stderr, not stdout.
openshift-ci-robot
added
the
approved
…t preserved. Also, update TODOs with functions handling schema conversions to drop support for Schema v1 in future release.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@sallyom: All pull requests linked via external trackers have merged: openshift/oc#493. Bugzilla bug 1850931 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add warning when mirroring SchemaVersion:1 images that digests are not preserved.
Also, update TODOs with functions handling schema conversions to drop support for Schema v1 in future release.
/assign @soltysh