must-gather: use exponential backoff for polling #523
Conversation
When running must-gather on a bare metal cluster, the command will fail to find the pod after a 1 minute duration, and exit with an error message in the form of `Get: $pod-url: unexpected EOF`. This patch replaces the normal way of polling (every 1 minute), with an exponential backoff starting with 1 second, and a factor of 2. The timeout value is unchanged. Bug 1859972 Signed-off-by: Yuval Turgeman <yturgema@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuvalturg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
| func (o *MustGatherOptions) waitForPodRunning(pod *corev1.Pod) error { | ||
| phase := pod.Status.Phase | ||
| err := wait.PollImmediate(time.Minute, time.Duration(o.Timeout)*time.Second, func() (bool, error) { | ||
| err := wait.ExponentialBackoff(o.getBackoff(), func() (bool, error) { |
There was a problem hiding this comment.
Does shortening this initial timeout like here #527 does the trick for you? Why you're proposing the exponential backoff?
There was a problem hiding this comment.
I thought you needed a longer interval, so I figured this was a decent compromise. If #527 works for you, then yes, it will solve our issue as well and we can close this.
|
Closing this in favor of #527 |
When running must-gather on a bare metal cluster, the command will fail
to find the pod after a 1 minute duration, and exit with an error
message in the form of
Get: $pod-url: unexpected EOF.This patch replaces the normal way of polling (every 1 minute), with an
exponential backoff starting with 1 second, and a factor of 2. The
timeout value is unchanged.
Bug 1859972
Signed-off-by: Yuval Turgeman yturgema@redhat.com