-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1888192: add rsync & log re-tries #631
Bug 1888192: add rsync & log re-tries #631
Conversation
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a00be68
to
817b529
Compare
@soltysh: This pull request references Bugzilla bug 1888192, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@soltysh: This pull request references Bugzilla bug 1888192, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@soltysh: This pull request references Bugzilla bug 1888192, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion to move the isGatherDone b4 the lost logs message, other than that lgtm.
// to ensure we don't print all of history set since to past 2 seconds | ||
opts.Options.(*corev1.PodLogOptions).SinceSeconds = &since2s | ||
|
||
if done, _ := o.isGatherDone(pod); done { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this above the klog "lost logs, re-trying", so that only prints if !isGatherDone -
(see easily w/ oc adm must-gather --dest-dir=/tmp/must-gather -v=4 -- date
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, updated.
817b529
to
328a720
Compare
4eb3595
to
6270927
Compare
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
/hold cancel |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@soltysh: All pull requests linked via external trackers have merged: Bugzilla bug 1888192 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.6 |
@damemi: new pull request created: #760 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The --timeout approach landed back in ad2dbe0 (Dump iptables on every node during teardown, 2019-01-24, openshift#2652). But oc dropped the deprecated --timeout option in openshift/oc@8931142584 (Remove deprecated --timeout flag from oc rsh, 2021-01-25, openshift/oc#631). That change landed in 4.7 and was backported to 4.6.23 [1], but not to 4.5. I've confirmed with Dan Winship that we still want the iptables saves, and don't just want to drop these blocks. Generated with: $ sed -i 's/rsh --timeout=20/--request-timeout=20s rsh/' $(git --no-pager grep -l 'rsh.*timeout' ci-operator) [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1926172#c7
There are 2 main issues with
oc adm must-gather
that this PR addresses:/assign @sallyom