Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift/oc: Force rpms to be build in CI #4855

Merged
merged 2 commits into from
Aug 27, 2019
Merged

openshift/oc: Force rpms to be build in CI #4855

merged 2 commits into from
Aug 27, 2019

Conversation

tnozicka
Copy link
Contributor

Currently the 'rpms' target doesn't fail the CI as seen in openshift/oc#71

/cc @soltysh

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2019
tnozicka
tnozicka commented Aug 27, 2019
View reviewed changes
ci-operator/config/openshift/oc/openshift-oc-master.yaml Outdated
@@ -57,6 +57,10 @@ resources:
memory: 6Gi
rpm_build_commands: make rpm-build
rpm_build_location: _output/rpms/
raw_steps:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevekuznetsov is it expected NOT to fail on rpm build errors? I guess the target doesn't get even build since nothing consumes it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and is this the correct magic to do so?

@tnozicka tnozicka force-pushed the force-rpm-build branch 2 times, most recently from 44e38ec to 2f96e6a Compare August 27, 2019 11:38
tnozicka
tnozicka commented Aug 27, 2019
View reviewed changes
ci-operator/config/openshift/oc/openshift-oc-master.yaml Outdated
- from: base
to: force-rpms-to-be-built
inputs:
rpms:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one seems to work https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/4855/rehearse-4855-pull-ci-openshift-oc-master-images/2#0:build-log.txt%3A21

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2019
@tnozicka tnozicka force-pushed the force-rpm-build branch 4 times, most recently from 48c70b3 to 719bd22 Compare August 27, 2019 14:12
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2019
@tnozicka
Copy link
Contributor Author

green https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/4855/rehearse-4855-pull-ci-openshift-oc-master-test-rpms/1

soltysh
soltysh approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f912d71 into openshift:master Aug 27, 2019
@openshift-ci-robot
Copy link
Contributor

@tnozicka: Updated the following 9 configmaps:

  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-oc-release-4.3.yaml using file ci-operator/config/openshift/oc/openshift-oc-release-4.3.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-oc-release-4.3.yaml using file ci-operator/config/openshift/oc/openshift-oc-release-4.3.yaml
  • job-config-4.2 configmap in namespace ci using the following files:
    • key openshift-oc-release-4.2-presubmits.yaml using file ci-operator/jobs/openshift/oc/openshift-oc-release-4.2-presubmits.yaml
  • job-config-4.3 configmap in namespace ci using the following files:
    • key openshift-oc-release-4.3-presubmits.yaml using file ci-operator/jobs/openshift/oc/openshift-oc-release-4.3-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-oc-master.yaml using file ci-operator/config/openshift/oc/openshift-oc-master.yaml
  • ci-operator-4.2-configs configmap in namespace ci using the following files:
    • key openshift-oc-release-4.2.yaml using file ci-operator/config/openshift/oc/openshift-oc-release-4.2.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-oc-master-presubmits.yaml using file ci-operator/jobs/openshift/oc/openshift-oc-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-oc-master.yaml using file ci-operator/config/openshift/oc/openshift-oc-master.yaml
  • ci-operator-4.2-configs configmap in namespace ci-stg using the following files:
    • key openshift-oc-release-4.2.yaml using file ci-operator/config/openshift/oc/openshift-oc-release-4.2.yaml

In response to this:

Currently the 'rpms' target doesn't fail the CI as seen in openshift/oc#71

/cc @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka tnozicka deleted the force-rpm-build branch August 27, 2019 15:11
@openshift-ci-robot
Copy link
Contributor

@tnozicka: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/oc/release-4.3/e2e-aws-upgrade 1621bcc link /test pj-rehearse
ci/rehearse/openshift/oc/release-4.3/e2e-aws 1621bcc link /test pj-rehearse
ci/rehearse/openshift/oc/release-4.3/images 1621bcc link /test pj-rehearse
ci/prow/pj-rehearse 1621bcc link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@tnozicka @openshift-ci-robot @soltysh @openshift-merge-robot