Adding the flag --allow-not-recommended to oc adm upgrade #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
LalatenduMohanty
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test verify |
|
/test e2e-aws-upgrade |
LalatenduMohanty
force-pushed
the
ota-528-flag-allow-not-recommended
branch
2 times, most recently
from
f2b848a
to
4f9eee6
Compare
wking
reviewed
Dec 4, 2021
wking
reviewed
Dec 4, 2021
wking
reviewed
Dec 4, 2021
wking
reviewed
Dec 4, 2021
LalatenduMohanty
force-pushed
the
ota-528-flag-allow-not-recommended
branch
from
4f9eee6
to
7316d19
Compare
wking
reviewed
Dec 7, 2021
wking
reviewed
Dec 7, 2021
|
@LalatenduMohanty: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
reviewed
Dec 16, 2021
LalatenduMohanty
force-pushed
the
ota-528-flag-allow-not-recommended
branch
from
55b2321
to
7fd9ff8
Compare
So that users can upgrade to a version listed in Supported but not recommended updates. The list of versions can be seen with oc adm upgrade --include-not-recommended For details refer to https://github.com/openshift/enhancements/blob/2cc2d9b331532c852878a7c793f3a754914c824e/enhancements/update/targeted-update-edge-blocking.md Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
ota-528-flag-allow-not-recommended
branch
from
7fd9ff8
to
6c8d935
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
wking
added a commit
to wking/oc
that referenced
this pull request
Apr 14, 2022
… together 6c8d935 (Adding the flag --allow-not-recommended to oc adm upgrade, 2021-12-01, openshift#986) taught --to and --to-image about --allow-not-recommended. This commit extends that coverage to --to-latest, allowing folks to say "I want the latest supported update, even if that update is not currently recommended". Probably not the best idea to do that sort of thing, but that's generally true of --allow-not-recommended. To accomplish this change, I've consolidated into a single "user requested an update" case, where we use one of the three options (--to-latest, --to, or --to-image) to hunt for a target update, and then centralized logic to actually apply that target.
wking
added a commit
to wking/oc
that referenced
this pull request
Apr 14, 2022
… together 6c8d935 (Adding the flag --allow-not-recommended to oc adm upgrade, 2021-12-01, openshift#986) taught --to and --to-image about --allow-not-recommended. This commit extends that coverage to --to-latest, allowing folks to say "I want the latest supported update, even if that update is not currently recommended". Probably not the best idea to do that sort of thing, but that's generally true of --allow-not-recommended. To accomplish this change, I've consolidated into a single "user requested an update" case, where we use one of the three options (--to-latest, --to, or --to-image) to hunt for a target update, and then centralized logic to actually apply that target.
wking
added a commit
to wking/oc
that referenced
this pull request
Apr 14, 2022
… together 6c8d935 (Adding the flag --allow-not-recommended to oc adm upgrade, 2021-12-01, openshift#986) taught --to and --to-image about --allow-not-recommended. This commit extends that coverage to --to-latest, allowing folks to say "I want the latest supported update, even if that update is not currently recommended". Probably not the best idea to do that sort of thing, but that's generally true of --allow-not-recommended. To accomplish this change, I've consolidated into a single "user requested an update" case, where we use one of the three options (--to-latest, --to, or --to-image) to hunt for a target update, and then centralized logic to actually apply that target.
wking
added a commit
to wking/oc
that referenced
this pull request
Apr 14, 2022
… together 6c8d935 (Adding the flag --allow-not-recommended to oc adm upgrade, 2021-12-01, openshift#986) taught --to and --to-image about --allow-not-recommended. This commit extends that coverage to --to-latest, allowing folks to say "I want the latest supported update, even if that update is not currently recommended". Probably not the best idea to do that sort of thing, but that's generally true of --allow-not-recommended. To accomplish this change, I've consolidated into a single "user requested an update" case, where we use one of the three options (--to-latest, --to, or --to-image) to hunt for a target update, and then centralized logic to actually apply that target.
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/oc
that referenced
this pull request
Apr 21, 2022
… together 6c8d935 (Adding the flag --allow-not-recommended to oc adm upgrade, 2021-12-01, openshift#986) taught --to and --to-image about --allow-not-recommended. This commit extends that coverage to --to-latest, allowing folks to say "I want the latest supported update, even if that update is not currently recommended". Probably not the best idea to do that sort of thing, but that's generally true of --allow-not-recommended. To accomplish this change, I've consolidated into a single "user requested an update" case, where we use one of the three options (--to-latest, --to, or --to-image) to hunt for a target update, and then centralized logic to actually apply that target.
wking
added a commit
to wking/oc
that referenced
this pull request
Jan 26, 2023
Cleaning up some nits from 6c8d935 (Adding the flag --allow-not-recommended to oc adm upgrade, 2021-12-16, openshift#986).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that users can upgrade to a version listed in Supported but not
recommended updates. The list of versions can be seen with oc adm upgrade --include-not-recommended
For details refer to https://github.com/openshift/enhancements/blob/2cc2d9b331532c852878a7c793f3a754914c824e/enhancements/update/targeted-update-edge-blocking.md
https://issues.redhat.com/browse/OTA-528
Signed-off-by: Lalatendu Mohanty lmohanty@redhat.com