Make blackbox-exporter launcher a clickable link #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
This PR makes the output of the `blackbox-exporter` launcher script output a clickable link in the style of the `cluster-console` script. Signed-off-by: Chris Collins <collins.christopher@gmail.com>
clcollins
force-pushed
the
clickable_exporter_link
branch
from
37f3468
to
ede9d3a
Compare
Replaces the `0.0.0.0` with `127.0.0.1` in the blackbox-exporter output. This does not functionally change anything, but matches the external expectations that 127.0.0.1 is the port in use, to avoid confusion. The internal address for the port forward has to be 0.0.0.0 or it will be unavailable outside of the container. However, the external port map is still 127.0.0.1, and only available on the local machine, whether accessed via 127.0.0.1 or 0.0.0.0 in the browser. Signed-off-by: Chris Collins <collins.christopher@gmail.com>
|
/retest |
|
Nice! Thanks Chris! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins, rendhalver The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
The builds look to be failing on the gpg key for the gcloud-sdk repo. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the output of the
blackbox-exporterlauncher scriptoutput a clickable link in the style of the
cluster-consolescript.Signed-off-by: Chris Collins collins.christopher@gmail.com