Adds yq and ag utilities
#59
Conversation
| RUN /bin/bash -c "curl -sSLf -O $(curl -sSLf ${YQ_URL} -o - | jq -r '.assets[] | select(.name|test("linux_amd64$")) | .browser_download_url') " | ||
| # Check the binary and checksum match | ||
| # This is terrible, but not sure how to do this better. | ||
| RUN rhash -c checksums | grep Success:1 |
There was a problem hiding this comment.
https://stackoverflow.com/questions/21956954/how-to-check-the-checksum-through-commandline
seems to have a good solution for it I think
There was a problem hiding this comment.
I'm not sure that addresses the issue. The problem is rhash won't check just a single file, so when I check, it shows all the other release binaries from YQ as "missed" and returns 1. It also shows a single success, for the single binary that's been downloaded ( as Success:1) so I was grep-ing on the existence of that to have a return 0 while still doing some kind of validation.
I don't know how to do something better there. Ideally, rhash would just allow for a single-file check, or something like "allow missing", but I haven't found that it has any options like that.
There was a problem hiding this comment.
Ok, this can be fixed later and we know this is a hack for now, for me that is good enough
|
Please fix conflicts and I'll merge |
openshift-ci
bot
added
the
needs-rebase
|
@clcollins pinging here as I saw you are online |
Adds `yq` (yaml parsing utility) and `ag` (faster-than-grep recursive search tool) Signed-off-by: Christopher Collins <collins.christopher@gmail.com>
|
@georgettica Rebased, please have a look. |
openshift-ci
bot
removed
the
needs-rebase
|
/lgtm |
Adds
yq(yaml parsing utility) andag(faster-than-grep recursivesearch tool)
Signed-off-by: Christopher Collins collins.christopher@gmail.com