Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1849105: [release-4.5] Delete the storageclasses during uninstall #574

Merged
merged 2 commits into from Jun 23, 2020
Merged

Bug 1849105: [release-4.5] Delete the storageclasses during uninstall #574

merged 2 commits into from Jun 23, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #556

/assign raghavendra-talur

@raghavendra-talur
StorageCluster: refactor the finalizer logic
8b6955e 
The reconcile loop has grown a lot and with more additions coming in it
would be better to handle them in a separate function.

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
@raghavendra-talur
StorageCluster: delete the storageclasses during finalize
f64517e 
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 19, 2020
Merged
@raghavendra-talur
Copy link
Contributor

@jarrpa I could create a PR using the cherrypick comment but looks like I can't edit the title of this PR. Could you please update the title to refer to bug ID 1849105?

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ocs-operator-e2e-aws f64517e link /test ocs-operator-e2e-aws
ci/prow/red-hat-storage-ocs-ci-e2e-aws f64517e link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@raghavendra-talur raghavendra-talur mentioned this pull request Jun 22, 2020
Merged
@raghavendra-talur
Copy link
Contributor

To be merged after #575

@raghavendra-talur raghavendra-talur mentioned this pull request Jun 22, 2020
Merged
@raghavendra-talur
Copy link
Contributor

@jarrpa @obnoxxx Please take a look.

@raghavendra-talur
Copy link
Contributor

/retitle Bug 1849105: [release-4.5] Delete the storageclasses during uninstall

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Delete the storageclasses during uninstall Bug 1849105: [release-4.5] Delete the storageclasses during uninstall Jun 23, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1849105, which is invalid:

  • expected the bug to target the "OCS 4.5.0" release, but it targets "---" instead
  • expected Bugzilla bug 1849105 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1849105: [release-4.5] Delete the storageclasses during uninstall

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jarrpa
jarrpa approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jarrpa
Copy link
Member

jarrpa commented Jun 23, 2020

/test ocs-operator-e2e-aws

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@jarrpa
Copy link
Member

jarrpa commented Jun 23, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@jarrpa: This pull request references Bugzilla bug 1849105, which is invalid:

  • expected Bugzilla bug 1849105 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa jarrpa added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3c5a1de into red-hat-storage:release-4.5 Jun 23, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: . Bugzilla bug 1849105 has been moved to the POST state.

In response to this:

Bug 1849105: [release-4.5] Delete the storageclasses during uninstall

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

@egafford egafford Awaiting requested review from egafford

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees

@jarrpa jarrpa

@raghavendra-talur raghavendra-talur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @raghavendra-talur @openshift-ci-robot @jarrpa @openshift-merge-robot