Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ansible 2.5.7 #10320

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

tomassedovic
Copy link
Contributor

This relaxes the Ansible version checking to allow 2.5.7.

While it is recommended to stick with 2.6, some of the packages are not
avaliable for systems running the current Long Term Support version of
OpenStack (Queens / OSP 13).

https://bugzilla.redhat.com/show_bug.cgi?id=1626538
https://bugzilla.redhat.com/show_bug.cgi?id=1635293

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomassedovic
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdodson

If they are not already assigned, you can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tomassedovic
Copy link
Contributor Author

I have tested this against OpenStack Queens with the following Ansible dependencies:

# requirements.txt 
openstacksdk==0.11.3
python-openstackclient===3.14.2
python-heatclient===1.14.0
osc-lib===1.9.0
os-client-config===1.29.0
shade==1.27.1
ansible==2.5.7
(ansible-2.5.7) 

These should match the versions in OSP 13 in https://bugzilla.redhat.com/show_bug.cgi?id=1626538.

If this gets accepted, I'll backport it to 3.11 so that can be run on OpenStack LTS as well.

@tzumainn
Copy link
Contributor

tzumainn commented Oct 4, 2018

I've tested this against queens as well (using packstack), and things seem to work!

@tomassedovic
Copy link
Contributor Author

/cherrypick release-3.11

@openshift-cherrypick-robot

@tomassedovic: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

@tomassedovic: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2018
This relaxes the Ansible version checking to allow 2.5.7.

While it is recommended to stick with 2.6, some of the packages are not
avaliable for systems running the current Long Term Support version of
OpenStack (Queens / OSP 13).

https://bugzilla.redhat.com/show_bug.cgi?id=1626538
https://bugzilla.redhat.com/show_bug.cgi?id=1635293
@sdodson
Copy link
Member

sdodson commented Oct 22, 2018

/lgtm

@sdodson sdodson merged commit 188641d into openshift:master Oct 22, 2018
@sdodson
Copy link
Member

sdodson commented Oct 22, 2018

/cherrypick releae-3.11

@celebdor
Copy link
Contributor

/cherrypick release-3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants