Propose adding ManageIQ service account by default #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch?
|
enoodle
changed the title
|
I'll let @wshearn weigh in here, I'm not sure how this would affect his process. |
|
@wshearn can you review? |
|
It shouldn't be too much of an impact for us. Though shouldn't this be set to true inside openshift_facts.py instead for consistency?(It is where we enable sdn, flannel, fluentd, etc) |
enoodle
force-pushed
the
propose_manageiq_as_default
branch
from
9faed26
to
dde450d
Compare
|
@wshearn You are right, I fixed that. |
|
ok to test |
|
@enoodle please rebase. |
Signed-off-by: enoodle <efreiber@redhat.com>
enoodle
force-pushed
the
propose_manageiq_as_default
branch
from
dde450d
to
8753a3f
Compare
|
@wshearn please merge. |
brenton
added a commit
that referenced
this pull request
Jan 4, 2016
Propose adding ManageIQ service account by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: enoodle efreiber@redhat.com